This repository was archived by the owner on Sep 5, 2025. It is now read-only.
Fix WordPress Coding Standards for PHP, JS and SCSS files#1388
Merged
Ismail-elkorchi merged 2 commits intoAutomattic:masterfrom Apr 7, 2020
Ismail-elkorchi:fix-wpcs
Merged
Fix WordPress Coding Standards for PHP, JS and SCSS files#1388Ismail-elkorchi merged 2 commits intoAutomattic:masterfrom Ismail-elkorchi:fix-wpcs
Ismail-elkorchi merged 2 commits intoAutomattic:masterfrom
Ismail-elkorchi:fix-wpcs
Conversation
This was referenced Apr 5, 2020
Ismail-elkorchi
changed the title
Ismail-elkorchi
commented
Apr 6, 2020
|
|
||
| if ( ! defined( '_S_VERSION' ) ) { | ||
| // Replace the version number of the theme on each release. | ||
| define( '_S_VERSION', '1.0.0' ); |
Contributor
Author
There was a problem hiding this comment.
This PR (Automattic/underscores.me#73) for underscores.me deals with searching and replacing this constant with the theme slug.
This was referenced Apr 7, 2020
|
Wow this is awesome! Thank you. |
Contributor
Author
|
You're welcome @kangabell 😃. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR fixes the WordPress Coding Standards errors reported using the tooling of #1386
Related issue(s):