This repository was archived by the owner on Sep 5, 2025. It is now read-only.
WIP: Enable coding standards for JS files#1187
Closed
grappler wants to merge 1 commit intoAutomattic:masterfrom
Closed
WIP: Enable coding standards for JS files#1187grappler wants to merge 1 commit intoAutomattic:masterfrom
grappler wants to merge 1 commit intoAutomattic:masterfrom
Conversation
- Updated file headers to match the WP coding standards See: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/#file-headers - Save the length in the loop as a variable. See: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/#iteration
grappler
changed the title
Contributor
Author
|
The travis tests are now failing for jshint and jscs at the moment. I would like to run the JS files through ESLint before I update the code again. I am waiting for |
Contributor
Author
|
@ntwb Do you have an idea when |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When discussing in #1153 about activating PHPCS for JavaScript files we realized that there were a few issues to be fixed. This PR does that.
We should merge #1140 and #1153 before this.