Close small menu when user clicks outside #1375#1379
Close small menu when user clicks outside #1375#1379Ismail-elkorchi merged 2 commits intoAutomattic:masterfrom RonHolt:close-small-menu-on-click-outside
Conversation
|
I'm sorry to ask a stupid question, but what does the notice mean that "all checks have failed"? here: https://travis-ci.org/Automattic/_s/builds/609127585?utm_source=github_status&utm_medium=notification |
|
@currentcreative It means that there is either an error here or here. Basic sniffing that needs to be updated for the automated commit tests. |
|
Or it means that there really is a code sniff problem that needs to be fixed by the committer. |
|
|
|
Looks like the sniff files need to be updated. |
Ismail-elkorchi
left a comment
Ismail-elkorchi
left a comment
There was a problem hiding this comment.
Thank you @GitarMan for the work here. I've rebased the PR on master and changed the indentation from spaces to tabs to pass the WPCS tests.
Other than that, I tested this PR locally and it works as described.
|
Just saw all this, thanks for changing the indentation. Glad I was able to contribute! |
|
It's all my pleasure @GitarMan 🎉 |
5 participants
Changes proposed in this Pull Request:
When small (mobile) menu is toggled open, this feature closes the menu when the user taps or clicks outside the #site-navigation container variable.
Related issue(s):
Fixes #1375