This repository was archived by the owner on Sep 5, 2025. It is now read-only.
Remove unnecessary aria-expanded attribute on ul#1303
Merged
Ismail-elkorchi merged 1 commit intoAutomattic:masterfrom Apr 11, 2020
Merged
Remove unnecessary aria-expanded attribute on ul#1303Ismail-elkorchi merged 1 commit intoAutomattic:masterfrom
Ismail-elkorchi merged 1 commit intoAutomattic:masterfrom
Conversation
grappler
approved these changes
Jul 2, 2018
Contributor
grappler
left a comment
grappler
left a comment
There was a problem hiding this comment.
This looks good. It looks like https://codepen.io/svinkle/details/LDKwA/ from https://a11yproject.com/ does the same thing.
Remove another irrelevant instance of aria-expanded
Ismail-elkorchi
force-pushed
the
fix-aria-expanded
branch
from
4da78a9 to
b44cdae
Compare
Contributor
|
I removed one more instance of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Remove
aria-expandedattribute from<ul>element, as it should only be applied to the button controlling the showing/hiding of the menu. (See my comment on #1289 for more detail.)Related issue(s):
Fixes #1289