Skip to content
This repository was archived by the owner on Sep 5, 2025. It is now read-only.

Comments

Update Normalize.css to v7.0.0#1155

Closed
mtomas7 wants to merge 4 commits intoAutomattic:masterfrom
mtomas7:patch-2
Closed

Update Normalize.css to v7.0.0#1155
mtomas7 wants to merge 4 commits intoAutomattic:masterfrom
mtomas7:patch-2

Conversation

@mtomas7
Copy link
Contributor

@mtomas7 mtomas7 commented Jul 1, 2017

I condensed similar styles as it was in previous _s version, but if needed I have normal version too. Personally, I prefer the normal version, as it makes much easier to compare with the original Normalize.css source.

I condensed similar styles as it was in previous _s version, but if needed I have normal version too. Personally, I prefer the normal version, as it makes much easier to compare with the original Normalize.css source.
@grappler
Copy link
Contributor

grappler commented Jul 2, 2017

@mtomas7 Thanks! Could you also update sass/_normalize.scss too?

Just for future reference the lone modification that was made before #895 has been fixed upstream so we should be ok in updating. necolas/normalize.css@fe56763

@mtomas7
Copy link
Contributor Author

mtomas7 commented Jul 3, 2017

Sorry, but I only worked with LESS, perhaps someone else with more experience could do this?

@grappler
Copy link
Contributor

grappler commented Jul 3, 2017

From the looks of the sass/_normalize.scss file it is the same as the CSS so you don't need to know Sass to update it. In #1144 we were discussing about adding the version number to the Normalize header of the style.css.

mtomas7 added 2 commits July 18, 2017 17:59
To make it same as in _normalize.scss. This way there will be no need to update style.scss Normalize.css comment each time new version comes.
This was referenced Jul 19, 2017
@davidakennedy
Copy link
Contributor

@mtomas7 Any interest in updating things here? Thank you!

@crunnells
Copy link
Contributor

#1272 supercedes this PR, bringing us up to v8.0.0. Thanks for your initial work here @mtomas7!

@crunnells crunnells closed this Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants