Skip to content
This repository was archived by the owner on Sep 5, 2025. It is now read-only.

Comments

Update Normalize to 7.0.0#1179

Closed
bappi wants to merge 3 commits intoAutomattic:masterfrom
bappi:patch-6
Closed

Update Normalize to 7.0.0#1179
bappi wants to merge 3 commits intoAutomattic:masterfrom
bappi:patch-6

Conversation

@bappi
Copy link
Contributor

@bappi bappi commented Jul 11, 2017

Changes proposed in this Pull Request:

_normalize.scss and style.css

Related issue(s): there's a PR #1155 but it's not complete, here's the full changes required

@tyrann0us
Copy link

Duplicate of #1155?

@bappi
Copy link
Contributor Author

bappi commented Jul 11, 2017

I don't know what you mean by duplicate

@jrfnl
Copy link
Contributor

jrfnl commented Jul 11, 2017

@B-07 duplicate means that you are sending in a PR for something where there is already a PR open for the same.

On a completely different note: PLEASE describe what you are changing and why in your PR description.
Listing the files changed is useless as that's what the "Files changed" tab is all about.

@bappi
Copy link
Contributor Author

bappi commented Jul 11, 2017

As I mentioned, there's a PR which has partial changes that are required, I did the additional changes and created a new PR as I cannot modify others PR

@m-e-h
Copy link

m-e-h commented Jul 11, 2017

I think there is still discussion going on about how best to include normalize. #1144

@davidakennedy
Copy link
Contributor

Thanks for the pull request, @B-07! I'm going to close this in favor of #1155. It's cool to have you jump in and contribute, but let's give @mtomas7 a chance to see his PR through. 😄

If he doesn't have time, we can always reopen this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants