Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ arrow==1.4.0 ; python_full_version >= "3.9.2" and python_version < "4.0"
certifi==2026.1.4 ; python_full_version >= "3.9.2" and python_version < "4.0"
cffi==2.0.0 ; python_full_version >= "3.9.2" and platform_python_implementation != "PyPy" and python_version < "4.0"
charset-normalizer==3.4.4 ; python_full_version >= "3.9.2" and python_version < "4.0"
cryptography==46.0.3 ; python_full_version >= "3.9.2" and python_version < "4.0"
cryptography==46.0.4 ; python_full_version >= "3.9.2" and python_version < "4.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, ensure that version 46.0.4 of the cryptography package is compatible with the rest of the software and ensure it does not create any breaking changes. Also, consider automating the process of updating packages in your project to reduce manual effort and increase efficiency.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a version bump of the cryptography module. It's important to recognize the potential implications of updating security libraries like cryptography. Additionally, this library might be used in different places in the code, and this update might affect those functionalities. I recommend investigating the differences between 46.0.3 and 46.0.4 and ensuring that this update doesn't break anything. Also, please supplement with unit or integration tests to ensure existing systems work as intended after this update.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line changes the version of the cryptography package. Please ensure that this version upgrade does not introduce any breaking changes, particularly if other parts of your software rely on specific parts of cryptography's API that might have changed in the new version.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line changes the version of the 'cryptography' package. It is good practice to always update packages for security implications and bug fixes, but it also runs the risk of introducing new bugs. Please make sure that the upgrade doesn't break anything in the current codebase or introduce new security threats. Also, consider adding a comment indicating why the specific upgrade from 'cryptography==46.0.3' to 'cryptography==46.0.4' was necessary.

flatdict==4.0.1 ; python_full_version >= "3.9.2" and python_version < "4.0"
idna==3.11 ; python_full_version >= "3.9.2" and python_version < "4.0"
jwcrypto==1.5.6 ; python_full_version >= "3.9.2" and python_version < "4.0"
Expand Down
Loading