Skip to content

fix #305: do render the value "0" inside conditional #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Krinkle wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix #305: do render the value "0" inside conditional #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e8ab9d
fix #305: do render the value "0" inside conditional
Krinkle Apr 2, 2019
e180a45
Merge branch 'master' into fix-zero
zordius Apr 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Runtime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public static function lo($cx, $v) {
public static function v($cx, $in, $base, $path, $args = null) {
$count = count($cx['scopes']);
$plen = count($path);
while ($base) {
while ($base !== null) {
Copy link
Contributor Author

@Krinkle Krinkle Apr 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the conditional block processes the path foo from the parent context with array( 'foo' => '0' ) the logic for deciding whether the value is "real" is on line 182, where it only has to pass isset().

The isset() function basically performs to checks: The variable/property/key exists, and has a non-null value.

This successfully unwraps the value '0' from array( 'foo' => '0' ).

The string '0' is then passed into the conditional closure, and Runtime::v() is called again when evaluating the placeholder {{foo}}. This time it is no longer a sub property, and it now implicitly checked by this while statement, which rejects all falsey values in PHP. Including many that isset() accepts. Such as: boolean false, number 0 and string '0'.

$v = $base;
foreach ($path as $i => $name) {
if (is_array($v)) {
Expand Down
12 changes: 12 additions & 0 deletions tests/regressionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1553,6 +1553,18 @@ public function issueProvider()
'expected' => 'ab'
),

Array(
'id' => 305,
'template' => '{{#foo}}<b>{{foo}}</b>{{/foo}}',
'options' => Array(
'flags' => LightnCandy::FLAG_ERROR_EXCEPTION | LightnCandy::FLAG_MUSTACHELOOKUP,
),
'data' => Array(
'foo' => '0',
),
'expected' => '<b>0</b>'
),

Array(
'template' => '{{#each . as |v k|}}#{{k}}{{/each}}',
'data' => Array('a' => Array(), 'c' => Array()),
Expand Down