Slightly fixed shaders building pipeline #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it included debug symbols unconditionally.
jeffoodchain
approved these changes
Dec 16, 2024
Collaborator
jeffoodchain
left a comment
jeffoodchain
left a comment
There was a problem hiding this comment.
Overall Looks Great to me, but having some personal questions :)
| .unwrap_or(false) | ||
| { | ||
| if cfg!(feature = "profiling-release") { | ||
| args.push("-frecord-sources"); |
Collaborator
There was a problem hiding this comment.
Some questions here:
- Do we generate
Metal Library Symbol Filevia this argument (-frecord-release)? - do we use the
symbol filesto do the profile our shaders?
Collaborator
Author
There was a problem hiding this comment.
Yeah, sure
- We do, according to this
-frecord-releasethis attribute does exactly this, that's why I moved it into the separate feature. - It's not quite, we're not required these symbols to be provided to exactly be capable to profile, but we still required these symbols to be provided to be capable to see what exactly shader is running. They're pretty much the same as the symbol files for ordinary binaries, they do nothing more but to enrich debug data with the exact function names (shader names in case of metal shaders obviously).
- According the same source we can skip the
.airintermediate compilation step and to compile shaders to its binary representation in a single shot, but I decided to implement this improvement after the refactor(metal_mont_backend): adapted from https://github.com/geometryxyz/msl-secp256k1 #13 will be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it included debug symbols unconditionally.