This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Update XMLImportExport.java #76
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor XML Export Logic for Stream Reusability and Maintainability
Summary of Changes
This pull request introduces a focused refactor of the
XMLImportExportclass to improve modularity, code reuse, and maintainability by:writeToStream(...)exportToFile(...)method to reuse thewriteToStream(...)logic-Preserving all existing behavior with no breaking changes
Motivation
The original export method tightly coupled file output with XML logic. By decoupling this into a reusable
writeToStream()method:Technical Details
writeToStream()takes an XMLEventWriter and handles the full RSS/XML generation process, including headers, molecule records, and unitsexportToFile()method now simply opens a file stream and passes it intowriteToStream()importFromFile()— only the export path is refactoredBackward Compatibility
This change does not break existing code. The exported files will remain identical, and external consumers using
exportToFile()will not be affected.