Skip to content

Comments

feat: run integration tests against Docker containers#39

Merged
mridang merged 1 commit intomainfrom
feat/containerised-integration-tests
Jun 11, 2025
Merged

feat: run integration tests against Docker containers#39
mridang merged 1 commit intomainfrom
feat/containerised-integration-tests

Conversation

@mridang
Copy link
Collaborator

@mridang mridang commented Jun 11, 2025

Description

This PR refactors the integration test setup to use TestContainers with Docker Compose instead of relying on a production instance. It ensures that integration tests run in a controlled, versioned environment without requiring sensitive production tokens, and enables public contributors to successfully run the tests in their pull requests.

Motivation and Context

The current integration tests depend on a production instance, causing issues such as failing public PR tests due to missing credentials and inconsistent environments. This change solves these problems by:

  • Ensuring tests can run consistently on a versioned setup.
  • Removing the need for sensitive production tokens.
  • Enabling public contributions to pass the integration tests.
  • Reducing reliance on external services for testing.

How Has This Been Tested?

  • Local Testing: I tested the new setup locally by running the integration tests using TestContainers with Docker Compose.
  • CI/CD Testing: I updated the GitHub Actions CI/CD pipeline to spin up the necessary containers and run tests.
  • Integration with Existing Code: Verified that the new setup does not break existing functionality and ensures all tests pass with the controlled test environment.

Documentation:

N/A

Checklist:

  • I have updated the documentation accordingly.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have requested a review from at least 2 reviewers.
  • I have checked the base branch of this pull request.
  • I have checked my code for any possible security vulnerabilities.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025

Qodana for Python

It seems all right 👌

No new problems were found according to the checks applied

@@ Code coverage @@
+ 73% total lines covered
773 lines analyzed, 572 lines covered
# Calculated according to the filters of your coverage tool

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@mridang mridang changed the title Feat/containerised integration tests feat: run integration tests against Docker containers Jun 11, 2025
@mridang mridang marked this pull request as draft June 11, 2025 11:59
@mridang mridang self-assigned this Jun 11, 2025
@mridang mridang added the enhancement New feature or request label Jun 11, 2025
@mridang mridang linked an issue Jun 11, 2025 that may be closed by this pull request
@mridang mridang force-pushed the feat/containerised-integration-tests branch from 8736ceb to 9746e66 Compare June 11, 2025 18:08
@mridang mridang marked this pull request as ready for review June 11, 2025 18:13
@mridang mridang merged commit 3cad058 into main Jun 11, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate integration tests to use a containerised environment

1 participant