Skip to content

Comments

Add Ballast min + max level entities#659

Merged
TheJulianJES merged 2 commits intozigpy:devfrom
TheJulianJES:tjj/ballast_entities
Feb 25, 2026
Merged

Add Ballast min + max level entities#659
TheJulianJES merged 2 commits intozigpy:devfrom
TheJulianJES:tjj/ballast_entities

Conversation

@TheJulianJES
Copy link
Contributor

@TheJulianJES TheJulianJES commented Feb 19, 2026

TODO: Translations in HA.

Proposed change

This adds minimum level and maximum level entities for the Ballast cluster. This is used by dimmers.

Additional information

Diagnostics for the Ubisys D1 dimmer will be added to test this.
We'll need to add translation keys to HA.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.49%. Comparing base (5576445) to head (de45663).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #659   +/-   ##
=======================================
  Coverage   97.48%   97.49%           
=======================================
  Files          62       62           
  Lines       10897    10917   +20     
=======================================
+ Hits        10623    10643   +20     
  Misses        274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor Author

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a minimum_level translation key with "Minimum load dimming level" as the translation in HA for the Inovelli devices: homeassistant/components/zha/strings.json#L731-L733

I think minimum_dimming_level with "Minimum dimming level" as the translation makes more sense. So, that's what we should add to HA IMO. We can change the Inovelli one in the future (if it has the same meaning – but if so, why didn't they use the Ballat cluster then?)

@TheJulianJES
Copy link
Contributor Author

Confirmed to work with Ubisys D1 dimmer. I'll add diagnostics dumps for all Ubisys deviecs in a follow-up PR when the quirks bump and all relevant ZHA entity changes are merged.

@TheJulianJES TheJulianJES marked this pull request as ready for review February 24, 2026 23:27
@TheJulianJES TheJulianJES merged commit 6dcd547 into zigpy:dev Feb 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant