Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 17, 2026

The repository includes CMakeLists.txt but CI only validates Makefile builds. This adds CMake build verification to catch configuration or compatibility issues.

Changes

  • Added CMake job to .github/workflows/check.yml:
    • Configures with cmake -B build -S .
    • Builds with cmake --build build
    • Tests the built module with luajit test/test.lua to ensure it works correctly
    • Checks out submodules (required for auxiliar/lua-compat dependencies)
    • Installs build dependencies: libluajit-5.1-dev, libssl-dev
    • Sets permissions: contents: read per GitHub security best practices

The job runs alongside existing checks (valgrind, asan, tsan, coverage) on every push and PR. All 221 tests pass with the CMake-built module.

Original prompt

This section details on the original issue you should resolve

<issue_title>enhance CI</issue_title>
<issue_description>Please add CMake build check in CI</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 17, 2026 03:29
Co-authored-by: zhaozg <542599+zhaozg@users.noreply.github.com>
Co-authored-by: zhaozg <542599+zhaozg@users.noreply.github.com>
Copilot AI changed the title [WIP] Enhance CI by adding CMake build check Add CMake build verification to CI Jan 17, 2026
Copilot AI requested a review from zhaozg January 17, 2026 03:32
@zhaozg
Copy link
Owner

zhaozg commented Jan 17, 2026

@copilot 对于 CMake 的输出成果有做test 吗, 运行 luajit test/test.lua 确保通过

Co-authored-by: zhaozg <542599+zhaozg@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 17, 2026

@copilot 对于 CMake 的输出成果有做test 吗, 运行 luajit test/test.lua 确保通过

Added test step in commit 9a3b90f. The CMake job now runs cd test && LUA_CPATH=../build/?.so luajit test.lua -v to verify the built module works correctly. All 221 tests pass.

@zhaozg zhaozg marked this pull request as ready for review January 17, 2026 03:46
@zhaozg zhaozg merged commit 0c4c963 into master Jan 17, 2026
@zhaozg zhaozg deleted the copilot/add-cmake-build-check branch January 17, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enhance CI

2 participants