Skip to content

[DEV-6953] Reordered the feeder equipment and direction assignment on database read#214

Merged
charlta merged 1 commit intomainfrom
DEV-6953-parallel-feeder-bugfix
Feb 4, 2026
Merged

[DEV-6953] Reordered the feeder equipment and direction assignment on database read#214
charlta merged 1 commit intomainfrom
DEV-6953-parallel-feeder-bugfix

Conversation

@charlta
Copy link
Member

@charlta charlta commented Feb 4, 2026

Description

When loading a database with parallel feeders in EWB, feeder directions were being assigned onto the zone substation bus, causing directional traces to traverse unexpected equipment. This was found to be because the feeder head check in the direction trace relies on the feeder head equipment being assigned to the feeder, which wasn't the case with the order of post processing traces in the database read.

Associated tasks

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

See new unit test or load a database with a parallel feeder and ensure feeder directions stop at both feeder heads instead of propagating onto the zone bus.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
    - [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Non-breaking.

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
@ryanjcoleman
Copy link
Member

Task linked: DEV-6953 Update Python SDK

@charlta charlta marked this pull request as ready for review February 4, 2026 00:52
@charlta charlta requested a review from a team February 4, 2026 00:53
@charlta charlta merged commit 752707d into main Feb 4, 2026
5 checks passed
@charlta charlta deleted the DEV-6953-parallel-feeder-bugfix branch February 4, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments