Conversation
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Member
|
Task linked: DEV-835 Update Python SDK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_schema_usage_point
test_network_service_translations
both fail, unusre why
Associated tasks
zepben/ewb-grpc#132
https://github.com/zepben/commons/pull/101
zepben/ewb-sdk-jvm#233
Test Steps
Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
Security
When developing applications, use following guidelines for information security considerations:
Documentation
Breaking Changes
Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.
Screenshots
Remove this section if the change cannot be shown through screenshots. Frontend changes should mostly include this section.
Screenshots can be copy-pasted into Github textboxes and a link will automatically be generated.
Remove this text if you choose to use this section.