Skip to content

[DEV-6709] Flush the "Waiting for model generation" message to output#38

Merged
vincewhite merged 2 commits intomainfrom
DEV-6709-Flush_output
Jan 21, 2026
Merged

[DEV-6709] Flush the "Waiting for model generation" message to output#38
vincewhite merged 2 commits intomainfrom
DEV-6709-Flush_output

Conversation

@vincewhite
Copy link
Member

@vincewhite vincewhite commented Jan 21, 2026

Description

Because the "Waiting for model generation" message doesn't end with a newline it generally isn't flushed to the screen/output. This change forces it to be flushed.

Associated tasks

NA

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Don't see how it could be.

Signed-off-by: vince <vince.white@zepben.com>
Signed-off-by: vince <vince.white@zepben.com>
@vincewhite vincewhite requested a review from AlexV-ZB January 21, 2026 04:03
Copy link
Member

@AlexV-ZB AlexV-ZB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vincewhite vincewhite merged commit d27ccd2 into main Jan 21, 2026
5 checks passed
@vincewhite vincewhite deleted the DEV-6709-Flush_output branch January 21, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants