[DEV 6656] Fix small bug in request_power_factory_models.py and add to dependency package.#37
Open
[DEV 6656] Fix small bug in request_power_factory_models.py and add to dependency package.#37
Conversation
…y package. Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
alourie
reviewed
Jan 15, 2026
Contributor
There was a problem hiding this comment.
The dependency addition looks good, will leave it to @chestm007 to judge the model fix
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was a small bug in the script where it's looking for lv feeders under normalEnergizedFeeders.
Also added a new dependency as it seems to be a requirement to prevent the SSL issue Endevour was seeing.Instead added a small FAQ section with two issue that the user could run into if they are trying to run the example codes from scratch.
LOOKING FOR INPUT:
So each of the function were written as a standalone example code and we print out messages to report what the script is doing or the result.
Should we update the script so that each function should return something that can be pass onto the next function for a single run end to end model acqusition.
This means we will have to change the download function to be a while loop until the model requested is complete among other things.
Associated tasks
List any other tasks / PRs that are required to be merged alongside this one (e.g. front end task for back end change or vice versa). If a PR exists, add a link. If not, just add an appropriate note here so reviewers know there is a dependency and will hold off merging until all things are ready.
Test Steps
Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
- [ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.- [ ] I have commented my code in any hard-to-understand or hacky areas.Security
When developing applications, use following guidelines for information security considerations:
Documentation
Breaking Changes
Should not break anything