Skip to content

[DEV 6656] Fix small bug in request_power_factory_models.py and add to dependency package.#37

Open
Esaotuelr wants to merge 4 commits intomainfrom
DEV-6656-fix-some-issue-in-ewb-example-python
Open

[DEV 6656] Fix small bug in request_power_factory_models.py and add to dependency package.#37
Esaotuelr wants to merge 4 commits intomainfrom
DEV-6656-fix-some-issue-in-ewb-example-python

Conversation

@Esaotuelr
Copy link
Member

@Esaotuelr Esaotuelr commented Jan 15, 2026

Description

There was a small bug in the script where it's looking for lv feeders under normalEnergizedFeeders.

Also added a new dependency as it seems to be a requirement to prevent the SSL issue Endevour was seeing.

Instead added a small FAQ section with two issue that the user could run into if they are trying to run the example codes from scratch.

LOOKING FOR INPUT:
So each of the function were written as a standalone example code and we print out messages to report what the script is doing or the result.
Should we update the script so that each function should return something that can be pass onto the next function for a single run end to end model acqusition.
This means we will have to change the download function to be a while loop until the model requested is complete among other things.

Associated tasks

List any other tasks / PRs that are required to be merged alongside this one (e.g. front end task for back end change or vice versa). If a PR exists, add a link. If not, just add an appropriate note here so reviewers know there is a dependency and will hold off merging until all things are ready.

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
    - [ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
    - [ ] I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Should not break anything

…y package.

Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
Copy link
Contributor

@alourie alourie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency addition looks good, will leave it to @chestm007 to judge the model fix

Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
@Esaotuelr Esaotuelr requested a review from alourie January 15, 2026 05:37
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants