[DEV-6652] allow leaving allocation_limit_per_year unspecified#52
Merged
[DEV-6652] allow leaving allocation_limit_per_year unspecified#52
Conversation
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Member
|
Task linked: DEV-6652 Use defaults in eas client python |
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
AlexV-ZB
approved these changes
Jan 18, 2026
Member
AlexV-ZB
left a comment
There was a problem hiding this comment.
I don't pretend to understand the exact code changes, but if it passed testing then I'm happy to deploy it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See title. This is done to avoid confusion in cases where the option is unused e.g. phase rebalancing.
Associated tasks
Tasks blocking this one:
Test Steps
Run intervention work package with
allocation_limit_per_yearunspecified. It should default to whatever EAS decides (should be 1 million)Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
- [ ] I have commented my code in any hard-to-understand or hacky areas.Security
When developing applications, use following guidelines for information security considerations:
Documentation
- [ ] I have updated any documentation required for these changes.(docs about running intervention completely missing. could update the examples instead)Breaking Changes
EAS must be upgraded to support null for
allocationLimitPerYear