Skip to content

[DEV-6652] allow leaving allocation_limit_per_year unspecified#52

Merged
Lax125 merged 6 commits intomainfrom
DEV-6652-nullable-allocation-limit
Jan 18, 2026
Merged

[DEV-6652] allow leaving allocation_limit_per_year unspecified#52
Lax125 merged 6 commits intomainfrom
DEV-6652-nullable-allocation-limit

Conversation

@Lax125
Copy link
Member

@Lax125 Lax125 commented Jan 15, 2026

Description

See title. This is done to avoid confusion in cases where the option is unused e.g. phase rebalancing.

Associated tasks

Tasks blocking this one:

Test Steps

Run intervention work package with allocation_limit_per_year unspecified. It should default to whatever EAS decides (should be 1 million)

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
    - [ ] I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
    - [ ] I have updated any documentation required for these changes. (docs about running intervention completely missing. could update the examples instead)

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

EAS must be upgraded to support null for allocationLimitPerYear

Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
@ryanjcoleman
Copy link
Member

Task linked: DEV-6652 Use defaults in eas client python

@Lax125 Lax125 requested a review from AlexV-ZB January 16, 2026 00:50
@Lax125 Lax125 marked this pull request as ready for review January 16, 2026 00:50
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Copy link
Member

@AlexV-ZB AlexV-ZB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't pretend to understand the exact code changes, but if it passed testing then I'm happy to deploy it

@Lax125 Lax125 merged commit a2349fb into main Jan 18, 2026
5 checks passed
@Lax125 Lax125 deleted the DEV-6652-nullable-allocation-limit branch January 18, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants