[DEV 3583] added span level threshold related functionality.#42
Merged
Conversation
Member
|
Task linked: DEV-3583 Update EAS Python Client |
clydeu
previously approved these changes
Aug 19, 2025
Member
clydeu
left a comment
There was a problem hiding this comment.
Looks sensible. Assuming new props are already in EAS then it should be good to go.
86b7dd1 to
439ba19
Compare
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
439ba19 to
892ef38
Compare
Signed-off-by: Kurt Greaves <kurt.greaves@zepben.com>
kgreav
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
enable span level threshold related functionality so it can be passed through to GQL call.
Associated tasks
List any other tasks / PRs that are required to be merged alongside this one (e.g. front end task for back end change or vice versa). If a PR exists, add a link. If not, just add an appropriate note here so reviewers know there is a dependency and will hold off merging until all things are ready.
Test Steps
Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
Security
When developing applications, use following guidelines for information security considerations:
Documentation
- [ ] I have updated any documentation required for these changes.Breaking Changes
Not breaking anything.