Skip to content

[DEV 3366] Added support for load/gen vMinPu and vMaxPu values, and ctPrimScalingFactor#34

Merged
kgreav merged 6 commits intomainfrom
DEV-3366-update-for-pu-rating-separation-and-ct-scaling
Jul 30, 2025
Merged

[DEV 3366] Added support for load/gen vMinPu and vMaxPu values, and ctPrimScalingFactor#34
kgreav merged 6 commits intomainfrom
DEV-3366-update-for-pu-rating-separation-and-ct-scaling

Conversation

@Esaotuelr
Copy link
Member

Description

Added support for load/gen vMinPu and vMaxPu values, and ctPrimScalingFactor.
There will be two PR chain to put these in but this PR should just be dependant of EAS.

Associated tasks

EAS

Test Steps

local spin up of EWB + EAS + Hosting capacity service and try to generate a model with run-hosting-capacity repo with local install of this branch.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
    - [ ] I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Documentation

  • I have updated the changelog.
    - [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

This will break all old configs for job running.

@Esaotuelr Esaotuelr requested review from adamwhite629 and clydeu July 8, 2025 00:37
@ryanjcoleman
Copy link
Member

Task linked: DEV-3366 Python EAS to cover both changes

@Esaotuelr Esaotuelr marked this pull request as draft July 8, 2025 01:01
…gFactor.

Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
@Esaotuelr Esaotuelr force-pushed the DEV-3366-update-for-pu-rating-separation-and-ct-scaling branch from 87ae177 to 976b2ed Compare July 30, 2025 01:48
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
@vincewhite vincewhite marked this pull request as ready for review July 30, 2025 05:26
Signed-off-by: vince <vince.white@zepben.com>
vincewhite
vincewhite previously approved these changes Jul 30, 2025
Copy link
Member

@vincewhite vincewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: vince <vince.white@zepben.com>
@kgreav kgreav merged commit 817fcdd into main Jul 30, 2025
4 checks passed
@kgreav kgreav deleted the DEV-3366-update-for-pu-rating-separation-and-ct-scaling branch July 30, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments