fix: handle ESC key to close plugin as advertised in the UI#3
Open
sudoytang wants to merge 1 commit intozellij-org:mainfrom
Open
fix: handle ESC key to close plugin as advertised in the UI#3sudoytang wants to merge 1 commit intozellij-org:mainfrom
sudoytang wants to merge 1 commit intozellij-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin's help text at the bottom of the screen already advertises
<ESC> - close. However, the update function had no handler for the Esc key event, so pressing ESC did nothing.I added a
BareKey::Escarm to the match block that callsclose_self(), making the plugin behave as the UI hint describes.Note that the newer version of rustup changed the target name to
wasm32-wasip1.