Open
Conversation
Verified "Welcome", "SPL-unit-tests", and "SimpleTestGuide" working for Windows, MinGW, Qt6.2.4
Updated CMAKE_PREFIX_PATH to look at most likely install path based on OS
…lt. In some rare cases, Windows does not load the gif icons. Converted icons to png and updated images.qrc ensure compatibility. https://doc.qt.io/qt-6/qimagewriter.html#supportedImageFormats
…ion. Modified the library CMakeLists.txt to copy resources folder into per-user writable data location from QtStandardPaths.
Updated CMakeLists.txt to include Qt6::Multimedia. Needed for changes to sounds library.
…ed on version number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds functionality that allows the stanford-cpp-library and related projects to be built from CMake rather than the Qt native qmake build system. Building from CMake makes it possible to use other IDEs for development.
I'm unsure if this should be left as a separate fork, merged, or documented as an option.
The following is a summary of the changes needed to build from CMake:
filelib_isDirectoryto beforefilelib_createDirectoryto fix a scope issuebuild.h.into accommodate CMake generation of thebuild.hfileI verified the CMake builds on CLion 2024 and Visual Studio Code. I also tested the build on MacOS, Linux, and Windows using the SPL-unit-tests.