Open
Conversation
Report for Shield (00bdde3 - 77511d4)📈 1 improvement in an unmatched item
Report for GZ2E01 (00bdde3 - 77511d4)No changesReport for ShieldD (00bdde3 - 77511d4)📈 Matched code: 49.24% (+0.02%, +3268 bytes) ✅ 28 new matches
📈 1 improvement in an unmatched item
Report for GZ2J01 (00bdde3 - 77511d4)No changesReport for RZDE01_00 (00bdde3 - 77511d4)📈 Matched code: 45.33% (+0.00%, +44 bytes) ✅ 1 new match
📈 1 improvement in an unmatched item
Report for RZDE01_02 (00bdde3 - 77511d4)📈 Matched code: 52.80% (+0.00%, +44 bytes) ✅ 1 new match
📈 1 improvement in an unmatched item
Report for RZDP01 (00bdde3 - 77511d4)📈 Matched code: 51.67% (+0.00%, +44 bytes) ✅ 1 new match
📈 1 improvement in an unmatched item
Report for RZDJ01 (00bdde3 - 77511d4)📈 Matched code: 51.99% (+0.00%, +44 bytes) ✅ 1 new match
📈 1 improvement in an unmatched item
Report for DZDE01 (00bdde3 - 77511d4)📈 Matched code: 50.27% (+0.00%, +44 bytes) ✅ 1 new match
📈 1 improvement in an unmatched item
Report for GZ2P01 (00bdde3 - 77511d4)No changes |
TakaRikka
reviewed
Feb 7, 2026
Comment on lines
+1573
to
+1585
| bool r27 = true; | ||
| bool r26 = true; | ||
| bool r25 = false; | ||
| if (0 <= i_no && i_no < (MEMORY_SWITCH|DAN_SWITCH|ZONE_SWITCH|ONEZONE_SWITCH)) { | ||
| r25 = true; | ||
| } | ||
| if (!r25 && i_no != -1) { | ||
| r26 = false; | ||
| } | ||
| if (!r26 && i_no != 255) { | ||
| r27 = false; | ||
| } | ||
| if (!r27) { |
Contributor
There was a problem hiding this comment.
this strongly appears like a chained condition in an assert. is there a way to get that to match here?
Contributor
Author
There was a problem hiding this comment.
With all of the conditions in the same if statement, I was not able to get it to generate the temp bools. I've seen this work elsewhere (and tweaked it to match), but I'm not sure what causes the compiler to do it in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.