Conversation
Report for SOUE01 (62fc066 - 3c3585e)📈 Matched code: 23.85% (+0.06%, +7844 bytes) ✅ 43 new matches
...and 13 more new matches 📈 11 improvements in unmatched items
|
src/d/tg/d_t_mass_object.cpp
Outdated
| } | ||
| } | ||
|
|
||
| // matches besides data |
There was a problem hiding this comment.
There's also a regalloc problem...
Adding the data splits should make data match?
elijah-thomas774
left a comment
elijah-thomas774
left a comment
There was a problem hiding this comment.
Seems like clang-format wasnt ran either
| } | ||
| } | ||
| dEmitterBase_c * ret; | ||
| switch (mMassObjSubtype) { |
There was a problem hiding this comment.
PARTICLE_RESOURCE_ID_MAPPING_120_ (ResID: 0x128) -> Light Blue-Green with yellow (normal grass)
PARTICLE_RESOURCE_ID_MAPPING_121_ (ResID: 0x129) -> Dead Shrub
PARTICLE_RESOURCE_ID_MAPPING_122_ (ResID: 0x12A) -> Dead Grass (Yellow - Lanayru)
PARTICLE_RESOURCE_ID_MAPPING_123_ (ResID: 0x12B) -> Vibrant Blue-green
PARTICLE_RESOURCE_ID_MAPPING_124_ (ResID: 0x12B) -> White with hints of purple
PARTICLE_RESOURCE_ID_MAPPING_687_ (ResID: 0x726) -> Vibrant Blue-green
PARTICLE_RESOURCE_ID_MAPPING_800_ (ResID: 0x830) -> White with hints of purple
PARTICLE_RESOURCE_ID_MAPPING_838_ (ResID: 0x880) -> idk (Flower based on shp emitter)
PARTICLE_RESOURCE_ID_MAPPING_839_ (ResID: 0x881) -> idk (Flower based on shp emitter)
PARTICLE_RESOURCE_ID_MAPPING_840_ (ResID: 0x882) -> idk (Flower based on shp emitter)
PARTICLE_RESOURCE_ID_MAPPING_841_ (ResID: 0x883) -> idk (Flower based on shp emitter)
| u16 getSpecificAttackDirection() const { | ||
| s32 getSpecificAttackDirection() const { | ||
| return mSpecificAttackDirection; | ||
| } |
There was a problem hiding this comment.
Looks like this change broke dAcBlastboss::checkForCounter... we don't know if inlines were used at all or if they were used inconsistently so we can also accept a duplicated inline for now.
There was a problem hiding this comment.
I just added casts for now
src/d/tg/d_t_mass_object.cpp
Outdated
| if (link->getSpecificAttackDirection() == 1 || link->getSpecificAttackDirection() == 0x10 || | ||
| link->getSpecificAttackDirection() == 0x100) { |
There was a problem hiding this comment.
I had added an enum for this (also below)
3 participants
No description provided.