Skip to content

(WIP): d_t_harp#263

Draft
Asiern wants to merge 8 commits intozeldaret:mainfrom
Asiern:d_t_harp
Draft

(WIP): d_t_harp#263
Asiern wants to merge 8 commits intozeldaret:mainfrom
Asiern:d_t_harp

Conversation

@Asiern
Copy link
Contributor

@Asiern Asiern commented Nov 11, 2025

No description provided.

@elijah-thomas774
Copy link
Collaborator

Hi there!
Thank you for checking out the ss decomp and wanting to make a PR

I know its still marked as WIP - but quick things to note as you continue (You can ignore me if you already have a plan :P)

  1. The Below Pattern is sLib::calcTimer<u16>(u16*) - an inline that will autogenerate when used in another function
unsigned short fn_536_690(unsigned short *param_1) {
    if (*param_1 != 0) {
        *param_1 = *param_1 + -1;
    }
    return *param_1;
}
  1. we have some basic typedefs to aid with the fundamental types (see "common.h")
    things like unsigned short will become u16 and short will be s16

As always, if you have any questions with how to complete functions or want feedback, you can also ask in the zeldaret discord or in the PR comment threads.

Thank you!

@elijah-thomas774
Copy link
Collaborator

elijah-thomas774 commented Nov 15, 2025

Note:
At the time of pre-generating the headers, the Tg actors inherit from dAcBase_c.
This is actually incorrect and need to inherit from dTg_c

Also in the class init in Ghidra, take a look at the vtable:
image

Based on this, we can see that:
fn_536_420 -> virtual bool createHeap() override
fn_536_430 -> virtual int create() override
fn_536_530 -> virtual int doDelete() override
fn_536_540 -> virtual int actorExecute() override
fn_536_580 -> virtual int draw() override

fn_536_7B0 -> virtual ~dTgHarp_c() {}

@decomp-dev
Copy link

decomp-dev bot commented Nov 15, 2025

Report for SOUE01 (da46df4 - a3fa21a)

No changes

@Asiern Asiern force-pushed the d_t_harp branch 2 times, most recently from 3655d8e to a3fa21a Compare November 16, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants