Add new model renders by enzofc708 · Pull Request #142 · zeldaret/ph

enzofc708 · 2026-02-02T15:03:25Z

Decomping new classes that inherit from ModelRender

decomp-dev · 2026-02-02T15:04:10Z

Report for eur (`98cc0af` - `0c6c574`)

📈 Matched code: 2.13% (+0.07%, +2468 bytes)
📈 Linked code: 0.68% (+0.02%, +648 bytes)
📈 Matched data: 0.62% (+0.08%, +620 bytes)
📈 Linked data: 0.58% (+0.05%, +384 bytes)

✅ 45 new matches

Unit	Item	Bytes	Before	After
`src/14_Land/Render/FlowerModelRender`	`FlowerModelRender::vfunc_3c(ModelRenderCommandsData*)`	+456	0.00%	100.00%
`src/04_Load/Render/LinkModelRender_04`	`.data`	+240	0.00%	100.00%
`src/04_Load/Render/LinkModelRender_04`	`LinkModelRender::LinkModelRender(ItemModel*)`	+184	0.00%	100.00%
`src/14_Land/Render/SignModelRender`	`SignModelRender::CalculateBrokenSignState()`	+152	0.00%	100.00%
`src/00_Core/Render/MistModelRender`	`MistModelRender::vfunc_3c(ModelRenderCommandsData*)`	+144	0.00%	100.00%
`src/14_Land/Render/SpikeModelRender`	`SpikeModelRender::vfunc_3c(ModelRenderCommandsData*)`	+124	0.00%	100.00%
`src/14_Land/Render/SignModelRender`	`SignModelRender::SetImpactDirection(Vec3p*)`	+116	0.00%	100.00%
`src/14_Land/Render/SignModelRender`	`SignModelRender::SetTransparencyAfterDamage(ModelRenderCommandsData*)`	+112	0.00%	100.00%
`src/14_Land/Render/SignModelRender`	`SignModelRender::SignModelRender(ItemModel*)`	+96	0.00%	100.00%
`src/00_Core/Render/MapModelRender`	`.data`	+72	0.00%	100.00%
`src/00_Core/Render/MistModelRender`	`.data`	+72	0.00%	100.00%
`src/14_Land/Render/TreasureChestModelRender`	`.data`	+72	0.00%	100.00%
`src/14_Land/Render/TreasureChestModelRender`	`TreasureChestModelRender::vfunc_3c(ModelRenderCommandsData*)`	+72	0.00%	100.00%
`src/14_Land/Render/FlowerModelRender`	`.data`	+72	0.00%	100.00%
`src/14_Land/Render/SpikeModelRender`	`.data`	+72	0.00%	100.00%
`src/00_Core/Render/SkyboxModelRender`	`SkyboxModelRender::SkyboxModelRender(ItemModel*)`	+68	0.00%	100.00%
`src/00_Core/Render/SkyboxModelRender`	`SkyboxModelRender::SkyboxModelRender(ItemModel*)`	+68	0.00%	100.00%
`src/00_Core/Render/MistModelRender`	`MistModelRender::MistModelRender(ItemModel*)`	+68	0.00%	100.00%
`src/00_Core/Render/MapModelRender`	`MapModelRender::MapModelRender(ItemModel*)`	+64	0.00%	100.00%
`src/14_Land/Render/FlowerModelRender`	`FlowerModelRender::FlowerModelRender(ItemModel*, int, int)`	+64	0.00%	100.00%
`src/14_Land/Render/SpikeModelRender`	`SpikeModelRender::SpikeModelRender(ItemModel*)`	+64	0.00%	100.00%
`src/14_Land/Render/TreasureChestModelRender`	`TreasureChestModelRender::TreasureChestModelRender(ItemModel*)`	+56	0.00%	100.00%
`src/14_Land/Render/FlowerModelRender`	`FlowerModelRender::func_ov014_0212e234()`	+48	0.00%	100.00%
`src/00_Core/Render/MapModelRender`	`MapModelRender::HideModelCovers(ModelRenderCommandsData*)`	+44	0.00%	100.00%
`src/14_Land/Render/SignModelRender`	`SignModelRender::func_ov014_0212d50c(ModelRenderCommandsData*)`	+40	0.00%	100.00%
`src/04_Load/Actor/Navi/ActorNavi_04`	`NaviModelRender::NaviModelRender(ItemModel*)`	+32	0.00%	100.00%
`src/00_Core/Render/MapModelRender`	`MapModelRender::~MapModelRender()`	+28	0.00%	100.00%
`src/00_Core/Render/SkyboxModelRender`	`SkyboxModelRender::~SkyboxModelRender()`	+28	0.00%	100.00%
`src/00_Core/Render/MistModelRender`	`MistModelRender::~MistModelRender()`	+28	0.00%	100.00%
`src/14_Land/Render/TreasureChestModelRender`	`TreasureChestModelRender::~TreasureChestModelRender()`	+28	0.00%	100.00%

...and 15 more new matches

💔 1 broken match

Unit	Item	Bytes	Before	After
`src/04_Load/Actor/Navi/ActorNavi_04`	`ActorNaviBase_Unk3::ActorNaviBase_Unk3(ItemModel*)`	-32	100.00%	0.00%

📈 4 improvements in unmatched items

Unit	Item	Bytes	Before	After
`src/14_Land/Render/SignModelRender`	`SignModelRender::UpdateBrokenPiecePosition(ModelRenderCommandsData*)`	+260	0.00%	92.90%
`src/00_Core/Render/SkyboxModelRender`	`.data`	+90	0.00%	97.83%
`src/14_Land/Render/FlowerModelRender`	`.rodata`	+68	0.00%	57.14%
`src/14_Land/Render/SpikeModelRender`	`.rodata`	+9	0.00%	46.15%

Report for usa (`98cc0af` - `0c6c574`)

📈 Matched code: 2.11% (+0.07%, +2468 bytes)
📈 Linked code: 0.68% (+0.02%, +648 bytes)
📈 Matched data: 0.59% (+0.08%, +620 bytes)
📈 Linked data: 0.58% (+0.05%, +384 bytes)

✅ 45 new matches

Unit	Item	Bytes	Before	After
`src/14_Land/Render/FlowerModelRender`	`FlowerModelRender::vfunc_3c(ModelRenderCommandsData*)`	+456	0.00%	100.00%
`src/04_Load/Render/LinkModelRender_04`	`.data`	+240	0.00%	100.00%
`src/04_Load/Render/LinkModelRender_04`	`LinkModelRender::LinkModelRender(ItemModel*)`	+184	0.00%	100.00%
`src/14_Land/Render/SignModelRender`	`SignModelRender::CalculateBrokenSignState()`	+152	0.00%	100.00%
`src/00_Core/Render/MistModelRender`	`MistModelRender::vfunc_3c(ModelRenderCommandsData*)`	+144	0.00%	100.00%
`src/14_Land/Render/SpikeModelRender`	`SpikeModelRender::vfunc_3c(ModelRenderCommandsData*)`	+124	0.00%	100.00%
`src/14_Land/Render/SignModelRender`	`SignModelRender::SetImpactDirection(Vec3p*)`	+116	0.00%	100.00%
`src/14_Land/Render/SignModelRender`	`SignModelRender::SetTransparencyAfterDamage(ModelRenderCommandsData*)`	+112	0.00%	100.00%
`src/14_Land/Render/SignModelRender`	`SignModelRender::SignModelRender(ItemModel*)`	+96	0.00%	100.00%
`src/00_Core/Render/MapModelRender`	`.data`	+72	0.00%	100.00%
`src/00_Core/Render/MistModelRender`	`.data`	+72	0.00%	100.00%
`src/14_Land/Render/TreasureChestModelRender`	`.data`	+72	0.00%	100.00%
`src/14_Land/Render/TreasureChestModelRender`	`TreasureChestModelRender::vfunc_3c(ModelRenderCommandsData*)`	+72	0.00%	100.00%
`src/14_Land/Render/FlowerModelRender`	`.data`	+72	0.00%	100.00%
`src/14_Land/Render/SpikeModelRender`	`.data`	+72	0.00%	100.00%
`src/00_Core/Render/SkyboxModelRender`	`SkyboxModelRender::SkyboxModelRender(ItemModel*)`	+68	0.00%	100.00%
`src/00_Core/Render/SkyboxModelRender`	`SkyboxModelRender::SkyboxModelRender(ItemModel*)`	+68	0.00%	100.00%
`src/00_Core/Render/MistModelRender`	`MistModelRender::MistModelRender(ItemModel*)`	+68	0.00%	100.00%
`src/00_Core/Render/MapModelRender`	`MapModelRender::MapModelRender(ItemModel*)`	+64	0.00%	100.00%
`src/14_Land/Render/FlowerModelRender`	`FlowerModelRender::FlowerModelRender(ItemModel*, int, int)`	+64	0.00%	100.00%
`src/14_Land/Render/SpikeModelRender`	`SpikeModelRender::SpikeModelRender(ItemModel*)`	+64	0.00%	100.00%
`src/14_Land/Render/TreasureChestModelRender`	`TreasureChestModelRender::TreasureChestModelRender(ItemModel*)`	+56	0.00%	100.00%
`src/14_Land/Render/FlowerModelRender`	`FlowerModelRender::func_ov014_0212e234()`	+48	0.00%	100.00%
`src/00_Core/Render/MapModelRender`	`MapModelRender::HideModelCovers(ModelRenderCommandsData*)`	+44	0.00%	100.00%
`src/14_Land/Render/SignModelRender`	`SignModelRender::func_ov014_0212d50c(ModelRenderCommandsData*)`	+40	0.00%	100.00%
`src/04_Load/Actor/Navi/ActorNavi_04`	`NaviModelRender::NaviModelRender(ItemModel*)`	+32	0.00%	100.00%
`src/00_Core/Render/MapModelRender`	`MapModelRender::~MapModelRender()`	+28	0.00%	100.00%
`src/00_Core/Render/SkyboxModelRender`	`SkyboxModelRender::~SkyboxModelRender()`	+28	0.00%	100.00%
`src/00_Core/Render/MistModelRender`	`MistModelRender::~MistModelRender()`	+28	0.00%	100.00%
`src/14_Land/Render/TreasureChestModelRender`	`TreasureChestModelRender::~TreasureChestModelRender()`	+28	0.00%	100.00%

...and 15 more new matches

💔 1 broken match

Unit	Item	Bytes	Before	After
`src/04_Load/Actor/Navi/ActorNavi_04`	`ActorNaviBase_Unk3::ActorNaviBase_Unk3(ItemModel*)`	-32	100.00%	0.00%

📈 4 improvements in unmatched items

Unit	Item	Bytes	Before	After
`src/14_Land/Render/SignModelRender`	`SignModelRender::UpdateBrokenPiecePosition(ModelRenderCommandsData*)`	+260	0.00%	92.90%
`src/00_Core/Render/SkyboxModelRender`	`.data`	+90	0.00%	97.83%
`src/14_Land/Render/FlowerModelRender`	`.rodata`	+68	0.00%	57.14%
`src/14_Land/Render/SpikeModelRender`	`.rodata`	+9	0.00%	46.15%

enzofc708 added 8 commits February 2, 2026 11:42

add MapModelRender

cf3a4f8

add new functions

41c4093

aadd skyboxmodelrender.cpp

ccb26d7

add NaviModelRender

c59d6c7

full match linkmodelrender_04

d0aadb4

add MistModelRender.cpp

8e0c113

add BoxModelRender

cc44f64

rename boxmodelrender

5a7cba4

enzofc708 added 6 commits February 2, 2026 12:21

fix broken EUR matches

cf36ad6

finished SignModelRender

bca7134

started BombModelRender.cpp

0382d1d

renamed BombModelRender to FlowerModelRender

ba17024

fix eur TreasureChestModelRender match

bd093a1

add SpikeModelRender.cpp

0c6c574

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new model renders#142

Add new model renders#142
enzofc708 wants to merge 14 commits intozeldaret:mainfrom
enzofc708:addModelRenders

enzofc708 commented Feb 2, 2026

Uh oh!

decomp-dev bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

enzofc708 commented Feb 2, 2026

Uh oh!

decomp-dev bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Report for eur (98cc0af - 0c6c574)

Report for usa (98cc0af - 0c6c574)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

decomp-dev bot commented Feb 2, 2026 •

edited

Loading

Report for eur (`98cc0af` - `0c6c574`)

Report for usa (`98cc0af` - `0c6c574`)