Decomp functions related to BMG files 2 by Yanis002 · Pull Request #123 · zeldaret/ph

Yanis002 · 2025-07-19T16:44:12Z

Successor of #60, still not done but I wanted to open a draft PR, currently I only fixed the issues with the different vtables and I matched few functions but I'll focus on actual code from now I think

… but fail :gone:

decomp-dev · 2025-07-19T16:44:45Z

Report for usa (`32cc123` - `1c74095`)

Total code: 3622792 bytes (-2 bytes)
📈 Matched code: 1.48% (+0.03%, +1032 bytes)

✅ 31 new matches:

Unit	Function	Bytes	Before	After
`src/Main/Message/func_0203c72c`	`MsgProc_Type3::MsgProc_Type3()`	+272	0.00%	100.00%
`src/Main/Unknown/UnkStruct_0203dae0`	`UnkStruct_0203dae0::UnkStruct_0203dae0(unsigned char)`	+152	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_34(int)`	+132	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_68(int, int*)`	+112	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::vfunc_10(unsigned int, int)`	+79	2.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038ef4(int, int)`	+76	0.00%	100.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::vfunc_3c(int)`	+76	0.00%	100.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::MsgProc_Type2()`	+68	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038cb8(int)`	+60	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_70(int, int)`	+55	20.69%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038b40()`	+52	0.00%	100.00%
`src/Main/Message/func_0203c72c`	`MsgProc_Type3::~MsgProc_Type3()`	+48	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_08(int, int, short*, int)`	+40	0.00%	100.00%
`src/Main/Unknown/UnkStruct_0203dae0`	`UnkStruct_0203dae0::vfunc_18(UnkStruct_02032e7c*, int, int)`	+40	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_30()`	+36	0.00%	100.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::~MsgProc_Type2()`	+20	0.00%	100.00%
`src/Main/Unknown/UnkStruct_0203dae0`	`UnkStruct_0203dae0::func_0203de14(int)`	+16	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::~UnkStruct_02038aa0()`	+13	28.57%	100.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::func_02032f98(unsigned short*)`	+12	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::~UnkStruct_02038aa0()`	+12	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::~UnkStruct_02038aa0()`	+12	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_4c()`	+12	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_10(unsigned int, int)`	+12	0.00%	100.00%
`src/Main/Message/BMG`	`BMGGroups::func_020372f0(BMGFileIndex, short)`	+5	97.56%	100.00%
`src/Main/Unknown/UnkStruct_0203dae0`	`UnkStruct_0203dae0::func_0203de24()`	+5	91.08%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_38()`	+4	50.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_44(int, int)`	+4	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_60(func_0203b410_param1*, int, int)`	+4	0.00%	100.00%
`src/Main/Message/func_0203c72c`	`UnkClass_func_ov000_020d0644::~UnkClass_func_ov000_020d0644()`	+4	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_48()`	+3	0.85%	100.00%

...and 1 more new matches

💔 19 broken matches:

Unit	Function	Bytes	Before	After
`src/Main/Unknown/UnkStruct_0203dae0`	`UnkStruct_0203dae0::UnkStruct_0203dae0(unsigned char)`	-152	100.00%	0.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::vfunc_3C(int)`	-76	100.00%	0.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::MsgProc_Type2(int, short, int)`	-68	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_0203881c::UnkStruct_0203881c()`	-60	100.00%	0.00%
`src/Main/Message/func_0203c72c`	`MsgProc_Type3::~MsgProc_Type3()`	-48	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`UnkStruct_020386d8::vfunc_30()`	-40	100.00%	0.00%
`src/Main/Unknown/UnkStruct_0203dae0`	`UnkStruct_0203dae0::vfunc_18(int)`	-40	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`UnkStruct_020386d8::vfunc_24(int)`	-28	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`UnkStruct_020386d8::vfunc_08(unsigned int)`	-24	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`UnkStruct_020386d8::vfunc_28(int)`	-24	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032e7c::~UnkStruct_02032e7c()`	-20	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`UnkStruct_020386d8::~UnkStruct_020386d8()`	-20	100.00%	0.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::~MsgProc_Type2()`	-20	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::SetUnk_0c(unsigned short*)`	-12	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038b28()`	-12	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_4c(unsigned int, int)`	-12	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038b74()`	-4	100.00%	0.00%
`src/Main/Message/func_0203c72c`	`MsgProc_Type3::func_0203c83c()`	-4	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_58()`	-1	100.00%	33.33%

📈 19 improvements in unmatched functions:

Unit	Function	Bytes	Before	After
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::vfunc_08(int, int, short*, int)`	+249	0.45%	71.12%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_50(EntryINF1, unsigned int, short, UnkSubClass1_02256FF8*)`	+194	0.00%	70.29%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038b78()`	+149	0.00%	79.34%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::vfunc_18(UnkStruct_02032e7c*, int, int)`	+99	0.00%	80.48%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::vfunc_4c()`	+99	0.00%	83.12%
`src/Main/Unknown/UnkStruct_0203dae0`	`UnkStruct_0203dae0::func_0203dcfc(unsigned char, int, int, int)`	+49	79.13%	99.33%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::vfunc_14(int, int)`	+10	72.84%	82.64%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02039208(short)`	+4	0.00%	12.50%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02039250()`	+4	0.00%	4.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_0203951c()`	+4	0.00%	6.25%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::func_02033628(UnkStruct_02032e7c, unsigned short*, int)`	+1	0.00%	1.38%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::func_020338a8(UnkStruct_02032e7c*, int)`	+1	0.00%	4.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_0203955c()`	+1	0.00%	8.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_64(int)`	+1	0.00%	4.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02039440(int, int)`	+1	0.00%	2.67%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::func_0203c4ac(int, int)`	+1	0.00%	0.57%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::func_0203c5dc()`	+1	0.00%	0.56%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_1c(int, int*, int, int)`	0	0.45%	2.22%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_0203881c::vfunc_00()`	0	0.00%	40.00%

📉 104 regressions in unmatched functions:

Unit	Function	Bytes	Before	After
`src/Main/Message/func_0203c72c`	`MsgProc_Type3::MsgProc_Type3(int, short, int)`	-225	82.96%	0.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::func_0203c39c(int, int)`	-83	69.75%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_30(int, int)`	-18	24.95%	0.00%
`src/Main/Message/BMG`	`BMGFileInfo::func_0203728c(int)`	-9	59.32%	50.56%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_0203881c::func_02038858(int)`	-3	8.33%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_20(int, int*)`	-3	12.50%	0.45%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_54()`	-2	33.33%	0.70%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::func_02033214(int, int, int, unsigned char, int)`	-1	0.77%	0.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::vfunc_18(int)`	-1	1.29%	0.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::func_02033628(int, unsigned short*)`	-1	1.38%	0.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::func_020338a8(int, int)`	-1	4.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_0203881c::func_02038888()`	-1	0.80%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_0203881c::func_02038950(UnkStruct_02038aa0*, int)`	-1	0.53%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_0203881c::func_02038a80(int)`	-1	5.71%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_60()`	-1	4.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_64()`	-1	1.43%	0.00%
`main_6`	`func_0202d23c`	0	0.00%	0.00%
`main_6`	`UnkStruct_astruct_3::func_0202d23c(int, unsigned int, int, int, unsigned int, int, int, int)`	0	0.00%	0.00%
`src/Main/Message/BmgRelatedFunctions`	`func_0202d3bc(int, unsigned int, char, int, int, bool, int, int)`	0	0.48%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`func_02038758`	0	0.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`func_02038770`	0	0.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`func_0203878c`	0	0.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`func_020387a4`	0	0.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`func_020387cc`	0	0.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_0203881c::~UnkStruct_0203881c()`	0	0.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_10(int)`	0	0.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038c34()`	0	0.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038d20()`	0	0.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_2c()`	0	4.44%	0.37%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038f40(int, int)`	0	0.00%	0.00%

...and 74 more regressions in unmatched functions

decomp-dev · 2025-07-19T16:50:56Z

Report for eur (`32cc123` - `1c74095`)

Total code: 3622878 bytes (-2 bytes)
📈 Matched code: 1.54% (+0.09%, +3148 bytes)

✅ 49 new matches:

Unit	Function	Bytes	Before	After
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_2c()`	+588	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_64(int)`	+404	0.00%	100.00%
`src/Main/Message/func_0203c72c`	`MsgProc_Type3::MsgProc_Type3()`	+272	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_3c(int)`	+168	0.00%	100.00%
`src/Main/Unknown/UnkStruct_0203dae0`	`UnkStruct_0203dae0::UnkStruct_0203dae0(unsigned char)`	+152	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_34(int)`	+132	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203a35c()`	+132	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_5c(unsigned short, UnkStruct_0203b264, char, int)`	+116	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_68(int, int*)`	+112	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203c13c()`	+100	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203be08()`	+92	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::vfunc_10(unsigned int, int)`	+79	2.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038ef4(int, int)`	+76	0.00%	100.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::vfunc_3c(int)`	+76	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203a2c0()`	+76	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::~UnkStruct_020397f8()`	+72	0.00%	100.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::MsgProc_Type2()`	+68	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203bd8c(int)`	+64	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::~UnkStruct_020397f8()`	+64	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038cb8(int)`	+60	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_6c(int, int)`	+60	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_70(int, int)`	+55	20.69%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038b40()`	+52	0.00%	100.00%
`src/Main/Message/func_0203c72c`	`MsgProc_Type3::~MsgProc_Type3()`	+48	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203b0bc()`	+48	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_08(int, int, short*, int)`	+40	0.00%	100.00%
`src/Main/Unknown/UnkStruct_0203dae0`	`UnkStruct_0203dae0::vfunc_18(UnkStruct_02032e7c*, int, int)`	+40	0.00%	100.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_30()`	+36	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_02039ca8()`	+36	0.00%	100.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_4c()`	+32	0.00%	100.00%

...and 19 more new matches

💔 19 broken matches:

Unit	Function	Bytes	Before	After
`src/Main/Unknown/UnkStruct_0203dae0`	`UnkStruct_0203dae0::UnkStruct_0203dae0(unsigned char)`	-152	100.00%	0.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::vfunc_3C(int)`	-76	100.00%	0.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::MsgProc_Type2(int, short, int)`	-68	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_0203881c::UnkStruct_0203881c()`	-60	100.00%	0.00%
`src/Main/Message/func_0203c72c`	`MsgProc_Type3::~MsgProc_Type3()`	-48	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`UnkStruct_020386d8::vfunc_30()`	-40	100.00%	0.00%
`src/Main/Unknown/UnkStruct_0203dae0`	`UnkStruct_0203dae0::vfunc_18(int)`	-40	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`UnkStruct_020386d8::vfunc_24(int)`	-28	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`UnkStruct_020386d8::vfunc_08(unsigned int)`	-24	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`UnkStruct_020386d8::vfunc_28(int)`	-24	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032e7c::~UnkStruct_02032e7c()`	-20	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02037750`	`UnkStruct_020386d8::~UnkStruct_020386d8()`	-20	100.00%	0.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::~MsgProc_Type2()`	-20	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::SetUnk_0c(unsigned short*)`	-12	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038b28()`	-12	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_4c(unsigned int, int)`	-12	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038b74()`	-4	100.00%	0.00%
`src/Main/Message/func_0203c72c`	`MsgProc_Type3::func_0203c83c()`	-4	100.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_58()`	-1	100.00%	33.33%

📈 38 improvements in unmatched functions:

Unit	Function	Bytes	Before	After
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_40(int, int)`	+734	0.00%	70.36%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_44(int, int)`	+601	0.00%	83.12%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::UnkStruct_020397f8()`	+576	0.00%	99.47%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_58()`	+377	0.00%	90.72%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203b0ec(unsigned int)`	+370	0.00%	98.55%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_60(func_0203b410_param1*, int, int)`	+325	0.00%	72.76%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_50(EntryINF1, unsigned int, short, UnkSubClass1_02256FF8*)`	+310	0.00%	76.00%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203a6d0(int, int)`	+255	0.00%	88.68%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::vfunc_08(int, int, short*, int)`	+249	0.45%	71.12%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203a188(int, int)`	+222	0.00%	71.28%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_50(EntryINF1, unsigned int, short, UnkSubClass1_02256FF8*)`	+194	0.00%	70.29%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203c1a0()`	+169	0.00%	90.38%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_1c(int, int*, int, int)`	+159	0.00%	62.48%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203b764()`	+158	0.00%	90.07%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203c084()`	+158	0.00%	85.91%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02038b78()`	+149	0.00%	79.34%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::func_0203c25c(UnkStruct_020397f8*)`	+103	0.00%	96.22%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::vfunc_18(UnkStruct_02032e7c*, int, int)`	+99	0.00%	80.48%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::vfunc_4c()`	+99	0.00%	83.12%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_18(UnkStruct_02032e7c*, int, int)`	+89	0.00%	51.95%
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_48()`	+51	0.00%	98.85%
`src/Main/Unknown/UnkStruct_0203dae0`	`UnkStruct_0203dae0::func_0203dcfc(unsigned char, int, int, int)`	+49	79.13%	99.33%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::vfunc_14(int, int)`	+10	72.84%	82.64%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02039208(short)`	+4	0.00%	12.50%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_02039250()`	+4	0.00%	4.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_0203951c()`	+4	0.00%	6.25%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::func_02033628(UnkStruct_02032e7c, unsigned short*, int)`	+1	0.00%	1.38%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::func_020338a8(UnkStruct_02032e7c*, int)`	+1	0.00%	4.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::func_0203955c()`	+1	0.00%	8.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_64(int)`	+1	0.00%	4.00%

...and 8 more improvements in unmatched functions

📉 4029 regressions in unmatched functions:

Unit	Function	Bytes	Before	After
`src/Main/Message/func_0203c72c`	`MsgProc_Type3::MsgProc_Type3(int, short, int)`	-225	82.96%	0.00%
`src/Main/Message/func_0203c358`	`MsgProc_Type2::func_0203c39c(int, int)`	-83	69.75%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_30(int, int)`	-18	24.95%	0.00%
`src/Main/Message/BMG`	`BMGFileInfo::func_0203728c(int)`	-9	59.32%	50.56%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_0203881c::func_02038858(int)`	-3	8.33%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_20(int, int*)`	-3	12.50%	0.45%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_54()`	-2	33.33%	0.70%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::func_02033214(int, int, int, unsigned char, int)`	-1	0.77%	0.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::vfunc_18(int)`	-1	1.29%	0.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::func_02033628(int, unsigned short*)`	-1	1.38%	0.00%
`src/Main/Unknown/UnkStruct_02032f0c`	`UnkStruct_02032f0c::func_020338a8(int, int)`	-1	4.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_0203881c::func_02038888()`	-1	0.80%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_0203881c::func_02038950(UnkStruct_02038aa0*, int)`	-1	0.53%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_0203881c::func_02038a80(int)`	-1	5.71%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_60()`	-1	4.00%	0.00%
`src/Main/Unknown/UnkStruct_02038aa0`	`UnkStruct_02038aa0::vfunc_64()`	-1	1.43%	0.00%
`main_22`	`__sinit_02050ca0`	0	0.00%	0.00%
`main_22`	`.text`	0	0.00%	0.00%
`main_22`	`.L_0200355c`	0	0.00%	0.00%
`main_22`	`double unsigned __int128::*`	0	0.00%	0.00%
`main_22`	`IntrWait`	0	0.00%	0.00%
`main_22`	`RLUnCompReadNormalWrite8bit`	0	0.00%	0.00%
`main_22`	`LZ77UnCompReadByCallbackWrite16bit`	0	0.00%	0.00%
`main_22`	`WaitByLoop`	0	0.00%	0.00%
`main_22`	`Sqrt`	0	0.00%	0.00%
`main_22`	`CpuFastSet`	0	0.00%	0.00%
`main_22`	`IsDebugger`	0	0.00%	0.00%
`main_22`	`LZ77UnCompReadNormalWrite8bit`	0	0.00%	0.00%
`main_22`	`RLUnCompReadByCallbackWrite16bit`	0	0.00%	0.00%
`main_22`	`Halt`	0	0.00%	0.00%

...and 3999 more regressions in unmatched functions

Yanis002 added 25 commits July 18, 2025 02:16

bmg header improvements

a8df7ed

match stuff

f8d5521

more documentation from the essay and finally match func_020372f0

82d88d0

finally match data sections (s/o to lago) and trying to make progress…

da23e39

… but fail :gone:

match some vtables!!!

45bf333

out of the vtable trap

9335f8a

cleanup functions declarations

08cdf28

relocs and symbols changes

845be69

BMG.hpp: unk_14 -> pFile

75726d6

file reset

ae2a35a

updated symbols

9f63493

add missing declarations

52f57e7

merge back progress from backup

adcf6e2

merge back progress from backup 2

2d22661

merge back progress from backup 3

f3efc24

headers + config updates

dbdd05e

random fixes

02f67ca

merge back progress from backup 4

bc9706b

unk_14 -> pFile 2 (forgot to commit the source)

26fe791

merge back progress from backup 5

804d0e2

headers update

51ab132

fixes

8652346

symbol renames + sync us with eu

88117a9

vfunc sync + fix issues with MessageManager.cpp

08791f4

symbol fixes + fix vtable offsets

9c75346

fix build issues on eur

2540278

Yanis002 added 2 commits July 19, 2025 18:51

Merge remote-tracking branch 'upstream/main' into bmg2

266c913

accidental mistake

dba64df

Yanis002 added 9 commits July 19, 2025 21:59

dsd fix thumb-nop

0e15ae6

progress on UnkStruct_02032f0c

1c74095

remove SectionDAT1

372acda

match func_0203643c and random progress

d041854

vtables fixing

e645bad

remove useless thing

7cc1ac8

split 7750 and 86d8

59e25cc

reorder delinks

daeee07

documented something

6a32dc0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decomp functions related to BMG files 2#123

Decomp functions related to BMG files 2#123
Yanis002 wants to merge 37 commits intozeldaret:mainfrom
Yanis002:bmg2

Yanis002 commented Jul 19, 2025

Uh oh!

decomp-dev bot commented Jul 19, 2025 •

edited

Loading

Uh oh!

decomp-dev bot commented Jul 19, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Yanis002 commented Jul 19, 2025

Uh oh!

decomp-dev bot commented Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Report for usa (32cc123 - 1c74095)

Uh oh!

decomp-dev bot commented Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Report for eur (32cc123 - 1c74095)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

decomp-dev bot commented Jul 19, 2025 •

edited

Loading

Report for usa (`32cc123` - `1c74095`)

decomp-dev bot commented Jul 19, 2025 •

edited

Loading

Report for eur (`32cc123` - `1c74095`)