Started `TouchControl.cpp` by Yanis002 · Pull Request #111 · zeldaret/ph

Yanis002 · 2025-07-05T22:51:04Z

draft for now because I don't remember why I didn't opened a PR earlier

decomp-dev · 2025-07-05T22:52:12Z

Report for usa (`e5701a7` - `875ff06`)

📈 Matched code: 2.04% (+0.03%, +1036 bytes)
📈 Matched data: 0.51% (+0.00%, +4 bytes)

✅ 14 new matches

Unit	Item	Bytes	Before	After
`src/00_Core/Player/TouchControl_00`	`TouchControl::UpdateFlags(unsigned short)`	+280	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::UpdateWithStateFlags(TouchStateFlags*, unsigned short)`	+220	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::UpdateConditionally(TouchState*, unsigned short)`	+104	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::func_ov00_0207af38(unsigned short, bool)`	+100	0.00%	100.00%
`src/08_GameStart/Init`	`TouchControl::TouchControl()`	+80	0.00%	100.00%
`src/Main/Player/TouchControl`	`TouchControl::func_0202b894(Vec3p*, int, char)`	+80	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::Update(TouchState*, unsigned short)`	+64	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::Init()`	+60	0.00%	100.00%
`src/Main/Player/TouchControl`	`TouchControl::func_0202b864(Vec3p*, int, char)`	+48	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`__sinit_TouchControl_00.cpp`	+44	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::func_ov00_0207aeac()`	+36	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::IncreaseSpeed(unsigned short)`	+24	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`.ctor`	+4	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::~TouchControl()`	+4	0.00%	100.00%

💔 3 broken matches

Unit	Item	Bytes	Before	After
`src/08_GameStart/Init`	`TouchControl::TouchControl()`	-80	100.00%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::IncreaseSpeed(short)`	-24	100.00%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::~TouchControl()`	-4	100.00%	0.00%

📉 7 regressions in unmatched functions

Unit	Item	Bytes	Before	After
`src/00_Core/Player/TouchControl`	`TouchControl::func_ov00_0207af38(unsigned short, bool)`	-92	92.00%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::func_ov00_0207aeac()`	-31	88.78%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::UpdateFlags(unsigned short)`	-4	1.43%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::UpdateWithStateFlags(TouchStateFlags*, unsigned short)`	-3	1.73%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::Update(TouchState*, unsigned short)`	-3	5.94%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::UpdateConditionally(TouchState*, unsigned short)`	-1	1.54%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::Init()`	0	1.38%	0.00%

Report for eur (`e5701a7` - `875ff06`)

📈 Matched code: 2.06% (+0.03%, +1036 bytes)
📈 Matched data: 0.54% (+0.00%, +4 bytes)

✅ 14 new matches

Unit	Item	Bytes	Before	After
`src/00_Core/Player/TouchControl_00`	`TouchControl::UpdateFlags(unsigned short)`	+280	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::UpdateWithStateFlags(TouchStateFlags*, unsigned short)`	+220	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::UpdateConditionally(TouchState*, unsigned short)`	+104	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::func_ov00_0207af38(unsigned short, bool)`	+100	0.00%	100.00%
`src/08_GameStart/Init`	`TouchControl::TouchControl()`	+80	0.00%	100.00%
`src/Main/Player/TouchControl`	`TouchControl::func_0202b894(Vec3p*, int, char)`	+80	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::Update(TouchState*, unsigned short)`	+64	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::Init()`	+60	0.00%	100.00%
`src/Main/Player/TouchControl`	`TouchControl::func_0202b864(Vec3p*, int, char)`	+48	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`__sinit_TouchControl_00.cpp`	+44	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::func_ov00_0207aeac()`	+36	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::IncreaseSpeed(unsigned short)`	+24	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`.ctor`	+4	0.00%	100.00%
`src/00_Core/Player/TouchControl_00`	`TouchControl::~TouchControl()`	+4	0.00%	100.00%

💔 3 broken matches

Unit	Item	Bytes	Before	After
`src/08_GameStart/Init`	`TouchControl::TouchControl()`	-80	100.00%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::IncreaseSpeed(short)`	-24	100.00%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::~TouchControl()`	-4	100.00%	0.00%

📈 1 improvement in unmatched functions

Unit	Item	Bytes	Before	After
`src/Main/Unknown/UnkStruct_020397f8`	`UnkStruct_020397f8::vfunc_44(int, int)`	+3	83.12%	83.55%

📉 7 regressions in unmatched functions

Unit	Item	Bytes	Before	After
`src/00_Core/Player/TouchControl`	`TouchControl::func_ov00_0207af38(unsigned short, bool)`	-92	92.00%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::func_ov00_0207aeac()`	-31	88.78%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::UpdateFlags(unsigned short)`	-4	1.43%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::UpdateWithStateFlags(TouchStateFlags*, unsigned short)`	-3	1.73%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::Update(TouchState*, unsigned short)`	-3	5.94%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::UpdateConditionally(TouchState*, unsigned short)`	-1	1.54%	0.00%
`src/00_Core/Player/TouchControl`	`TouchControl::Init()`	0	1.38%	0.00%

Yanis002 · 2026-01-30T16:03:36Z

marking as ready to review, I improved things but I couldn't mark as complete because of gTouchControl, it's in the main module but the related init function is in overlay 0 so idk what to do about it

Yanis002 added 2 commits July 2, 2025 19:48

start both TouchControl.cpp

fd4201b

Merge remote-tracking branch 'upstream/main' into touchcontrol

1b8caa9

Yanis002 and others added 3 commits July 13, 2025 15:17

Merge remote-tracking branch 'upstream/main' into touchcontrol

4920e76

Merge remote-tracking branch 'upstream/main' into touchcontrol

77367db

Merge remote-tracking branch 'upstream/main' into touchcontrol

c10deaf

Yanis002 mentioned this pull request Sep 22, 2025

Decomp TouchControl.cpp (43%) #136

Closed

Yanis002 added 5 commits September 23, 2025 00:16

Merge remote-tracking branch 'upstream/main' into touchcontrol

ffd1cb7

fix build issues

a422016

Merge remote-tracking branch 'upstream/main' into touchcontrol

11c629c

complete touchcontrol

321ccf9

remove useless comment

875ff06

Yanis002 marked this pull request as ready for review January 30, 2026 16:02

AetiasHax approved these changes Jan 30, 2026

View reviewed changes

AetiasHax merged commit 98cc0af into zeldaret:main Jan 30, 2026
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Started `TouchControl.cpp`#111

Started `TouchControl.cpp`#111
AetiasHax merged 10 commits intozeldaret:mainfrom
Yanis002:touchcontrol

Yanis002 commented Jul 5, 2025

Uh oh!

decomp-dev bot commented Jul 5, 2025 •

edited

Loading

Uh oh!

Yanis002 commented Jan 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Yanis002 commented Jul 5, 2025

Uh oh!

decomp-dev bot commented Jul 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Report for usa (e5701a7 - 875ff06)

Report for eur (e5701a7 - 875ff06)

Uh oh!

Yanis002 commented Jan 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

decomp-dev bot commented Jul 5, 2025 •

edited

Loading

Report for usa (`e5701a7` - `875ff06`)

Report for eur (`e5701a7` - `875ff06`)