feat(cli) port login command #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliangcs
approved these changes
Aug 30, 2019
Member
eliangcs
left a comment
eliangcs
left a comment
There was a problem hiding this comment.
I did some sanity tests and it looks good!
| this.log( | ||
| `\n\nNow you'll enter your Zapier password.\nIf you log into Zapier via the ${colors.green( | ||
| 'log in with Google button' | ||
| )}, you may not have a Zapier password.\nIf that's the case, go to https://zapier.com/app/login/forgot and create one.\n\n` |
| describe('BaseCommand', () => { | ||
| describe('log', () => { | ||
| beforeEach(() => { | ||
| // stdout.print = true; |
Member
There was a problem hiding this comment.
Does this commented line of code have any purpose? I suggest removing if not.
Contributor
Author
There was a problem hiding this comment.
it's helpful for testing, though it probably doesn't need to be included. Will pull!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the login command and fix some bugs.
Worth noting that this doesn't include the saml changes from zapier/zapier-platform-cli#420. It could, but we're still not positive on the url for that dashboard, so i'm going to hold off. Should be a fast enough follow once this is in though.
I'm not sure how we can test this or if it's easy to mock stdin.