This repository was archived by the owner on May 29, 2023. It is now read-only.
improve potential memory access overflow risk for #104 #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuber
force-pushed
the
bugfix/potential_memory_overflow
branch
from
019b7f0 to
11f0aa1
Compare
completely test for `tengine/ngx_http_upstream_check_module` and `tengine/ngx_http_upstream_consistent_hash_module` seperate unit test cases files for different module
cuber
force-pushed
the
bugfix/potential_memory_overflow
branch
from
11f0aa1 to
85ed958
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because life cycle of
cmcfis as long as the nginx worker, so updating this variable dynamically will case potential memory access overflow risksee the discussion A crash bugfix for ngx_http_dyups_module alibaba/tengine#1133
completely test for the modules below
tengine/ngx_http_upstream_check_moduletengine/ngx_http_upstream_consistent_hash_moduleseperate unit test cases files for different module