Added Visual Studio support for Windows #104
Open
+39
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds Visual Studio support for Windows by enabling line number jumping functionality and includes test coverage for the launch-editor package.
- Added Visual Studio executable detection and command-line argument formatting for line navigation
- Added comprehensive test coverage for the
getArgumentsForPositionfunction - Updated documentation to reflect Windows support for Visual Studio
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/launch-editor/package.json | Added test script configuration |
| packages/launch-editor/get-args.test.js | New test file covering Visual Studio and other editor argument formatting |
| packages/launch-editor/get-args.js | Added Visual Studio case handling for line navigation |
| packages/launch-editor/editor-info/windows.js | Added devenv.exe to Windows executable list |
| README.md | Updated Visual Studio Windows support status |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Author
|
Let me know if the test file is not needed, and I can remove it |
rlorenzo
force-pushed
the
windows-visual-studio
branch
2 times, most recently
from
0f59683 to
2caa22a
Compare
- Reusing the IDE window and jumping to a specific line number is not supported at the same time. Prefering to use the same window over jumping to a line number. - Added test file for launch-editor.
rlorenzo
force-pushed
the
windows-visual-studio
branch
from
2caa22a to
371bc28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.