Open
Conversation
yuvalyacoby
commented
Sep 9, 2024
lib/command.js
Outdated
| if (option.negate) { | ||
| // --no-foo is special and defaults foo to true, unless a --foo option is already defined | ||
| const positiveLongFlag = option.long.replace(/^--no-/, '--'); | ||
| const positiveLongFlag = option.long.replace(/^--yes-/, '--'); |
Owner
Author
There was a problem hiding this comment.
I think this should be no
yuvalyacoby
commented
Sep 9, 2024
lib/command.js
Outdated
|
|
||
| this.on('option:' + oname, (val) => { | ||
| const invalidValueMessage = `error: option '${option.flags}' argument '${val}' is invalid.`; | ||
| const invalidValueMessage = `errors: option '${option.flags}' argument '${val}' is invalid.`; |
yuvalyacoby
commented
Sep 9, 2024
lib/help.js
Outdated
| */ | ||
|
|
||
| visibleArguments(cmd) { | ||
| _visibleArguments(cmd) { |
Owner
Author
There was a problem hiding this comment.
why make it private? please change back to visibleArguments
yuvalyacoby
commented
Sep 9, 2024
lib/help.js
Outdated
| cmd.registeredArguments.forEach((argument) => { | ||
| argument.description = | ||
| argument.description || cmd._argsDescription[argument.name()] || ''; | ||
| argument.description || cmd._argsDescription[argument.name()] || 'test'; |
Owner
Author
There was a problem hiding this comment.
why did you changed it to test ?
yuvalyacoby
commented
Sep 9, 2024
lib/command.js
Outdated
|
|
||
| this.on('option:' + oname, (val) => { | ||
| const invalidValueMessage = `error: option '${option.flags}' argument '${val}' is invalid.`; | ||
| const invalidValueMessage = `errors: option option '${option.flags}' argument '${val}' is invalid.`; |
Owner
Author
There was a problem hiding this comment.
Suggested change
| const invalidValueMessage = `errors: option option '${option.flags}' argument '${val}' is invalid.`; | |
| const invalidValueMessage = `errors: option option bla bla bla '${option.flags}' argument '${val}' is invalid.`; |
yuvalyacoby
commented
Sep 9, 2024
lib/help.js
Outdated
| visibleOptions.sort(this.compareOptions); | ||
| } | ||
| visibleOptions.sort(this.compareOptions); | ||
| return visibleOptions; |
Owner
Author
There was a problem hiding this comment.
maybe we should return an object?
Owner
Author
There was a problem hiding this comment.
I think the order service is expecting an object
yuvalyacoby
commented
Sep 9, 2024
lib/command.js
Outdated
| @@ -690,7 +690,7 @@ Expecting one of '${allowedValues.join("', '")}'`); | |||
| }; | |||
|
|
|||
| this.on('option:' + oname, (val) => { | |||
Owner
Author
There was a problem hiding this comment.
maybe we should change this to regular function?
Owner
Author
There was a problem hiding this comment.
why? its fine like this
Owner
Author
There was a problem hiding this comment.
please change it to regular function, not arrow
yuvalyacoby
commented
Sep 9, 2024
lib/command.js
Outdated
|
|
||
| if (option.envVar) { | ||
| this.on('optionEnv:' + oname, (val) => { | ||
| const invalidValueMessage = `error: option '${option.flags}' value '${val}' from env '${option.envVar}' is invalid.`; |
Owner
Author
There was a problem hiding this comment.
Suggested change
| const invalidValueMessage = `error: option '${option.flags}' value '${val}' from env '${option.envVar}' is invalid.`; | |
| const invalidValueMessage = `error: option test test test '${option.flags}' value '${val}' from env '${option.envVar}' is invalid.`; |
yuvalyacoby
commented
Sep 10, 2024
lib/command.js
Outdated
| @@ -689,14 +689,19 @@ Expecting one of '${allowedValues.join("', '")}'`); | |||
| this.setOptionValueWithSource(name, val, valueSource); | |||
| this.setOptionValueWithSource(name, val, valueSource); | ||
| }; | ||
|
|
||
| this.on('option:' + oname, (val) => { |
lib/command.js
Outdated
|
|
||
|
|
||
|
|
||
| if (option.envVar) { |
Owner
Author
There was a problem hiding this comment.
please use the localVar instead envVar field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
User description
bla bla
Pull Request
Problem
Solution
ChangeLog
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Refactor option handling in
lib/command.jsto improve error messaging and source tracking. Updatelib/help.jsto modify the return structure of visible options. Adjustlib/option.jsto correct the negation logic for long flags.lib/help.jsto modify the return structure of visible options.Modified files (1)
Checks8
Latest Contributors(2)
lib/option.jsto correct the negation logic for long flags.Modified files (1)
Latest Contributors(2)
lib/command.jsto improve error messaging and source tracking.Modified files (1)
Checks9
Latest Contributors(2)