Open
Conversation
will not be installed on server (dev dependency)
match with upload-artifact er FAQ
Azure IDs are also required
prod doesn't need CORS since the client is served from the same domain as the API
* limit CD workflow_run trigger to non-for, non-pr, main branch only * debug GH context
only branch filter is necessary as explained in the comment The additional filters were either redundant or incorrect: 1. `github.event_name` is always `workflow_run` anyway 2. `workflow_run.event` can't be 'pull_request' because such a run's branch would never match `main` (see comment) 3. `github.event.workflow_run.head_repository.fork` is true for this repo because it's a fork in itself
Extra safeguard against pwn requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yuvalha96 - the checks in this PR supersede
client / test-npmandserver / test-npm, so please remove them from the repo's required checks (and replace with the modified checks below) so that we can merge this one.You can see the deployed app in the different envs: