[fix] take first result on YB_RELEASE check#35
Open
jlisthood wants to merge 1 commit intoyugabyte:masterfrom
Open
[fix] take first result on YB_RELEASE check#35jlisthood wants to merge 1 commit intoyugabyte:masterfrom
jlisthood wants to merge 1 commit intoyugabyte:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before running
./install_software.sh 2024.1.3.0would have multi-line values for YB_RELEASE, YB_PACKAGE_URL, and YB_PACKAGE_NAME:This would cause the install script to fail since
YB_PACKAGE_URLis not valid.wgetwould fail to grabhttps://downloads.yugabyte.com/releases/2024.1.3.0/yugabyte-2024.1.3.0-b105above.By taking the first result using
| head -n 1the install script works fine:In this case,
wget https://downloads.yugabyte.com/releases/2024.1.3.0/yugabyte-2024.1.3.0-b105-linux-x86_64.tar.gzends up succeedingI believe the root cause is that we see these 3 versions mentioned in release tags:
So the
grep -Eo "2024.1.3.0-b[0-9]+"matches all 3 and returns2024.1.3.0-b1053 times.