chore(Flow/FlowRedirect): minor fix [YTFRONT-5241]#1441
Merged
ma-efremoff merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideFlowRedirect now dispatches a flow filters update with the current pipeline path before performing the navigation redirect, ensuring filter state is synchronized with the target flow URL. Sequence diagram for FlowRedirect dispatching filters update before navigationsequenceDiagram
participant FlowRedirect
participant ReduxStore
participant filtersSlice
participant AppBrowserHistory
FlowRedirect->>ReduxStore: useSelector(getPath)
ReduxStore-->>FlowRedirect: path
FlowRedirect->>ReduxStore: dispatch updateFlowFilters(pipelinePath=path)
ReduxStore->>filtersSlice: updateFlowFilters(pipelinePath)
filtersSlice-->>ReduxStore: flowFilters updated
FlowRedirect->>AppBrowserHistory: replace(url=makeFlowLink(path))
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Storybook is ready. |
Contributor
|
Playwright components report is ready. |
Contributor
|
Statoscope report is ready. |
Contributor
|
E2E-local report is ready. |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The redirect and Redux dispatch are side effects and should use
useEffectinstead ofuseMemo, which is intended for memoizing computed values rather than performing actions. - Consider guarding the redirect/filters update when
pathis falsy to avoid dispatching and replacing history with an invalid or empty URL.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The redirect and Redux dispatch are side effects and should use `useEffect` instead of `useMemo`, which is intended for memoizing computed values rather than performing actions.
- Consider guarding the redirect/filters update when `path` is falsy to avoid dispatching and replacing history with an invalid or empty URL.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
SimbiozizV
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nda.ya.ru/t/RIIDfMjF7UfbuW
## Summary by SourceryBug Fixes: