Skip to content

Conversation

@cameronapak
Copy link
Collaborator

@cameronapak cameronapak commented Jan 6, 2026

https://lifechurch.atlassian.net/browse/YPE-1000

I wanted to test out the agent's files, so even though the agent's pull request isn't yet approved, I branched off of that to create this. Agents file PR: #90

Watch Video Overview

@cameronapak cameronapak self-assigned this Jan 6, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2026

⚠️ No Changeset found

Latest commit: c0eefdf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 6, 2026

Greptile Summary

Fixed Storybook loading error for Verse of the Day component by standardizing all mock data, handlers, and stories to use version 111 (NIV) instead of the mismatched version 1 (KJV). The issue occurred because the component requested passages from the API with version 1 by default, but the mock handler was configured to respond only to version 111 requests, causing the verse to fail to load in Storybook.

Key changes:

  • Updated all story definitions to explicitly pass versionId: 111
  • Changed mock handler endpoint from /v1/bibles/1/passages/ISA.43.19 to /v1/bibles/111/passages/ISA.43.19
  • Updated mock passage data to have version_id: 111 instead of version_id: 1
  • Updated test expectations from "KJV" to "NIV"
  • Removed unused version 1 Bible endpoint handler
  • Added .sisyphus/* to .gitignore for AI tooling

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are straightforward mock data updates that fix a clear mismatch between the API request and mock response. All changes are confined to test/story infrastructure with no impact on production code logic. The fix is complete and consistent across all affected files.
  • No files require special attention

Important Files Changed

Filename Overview
packages/ui/src/components/verse-of-the-day.stories.tsx Updated all story args and test expectations to use version 111 (NIV), fixing Storybook loading issues
packages/ui/src/test/mock-data/passages.json Changed Isaiah 43:19 mock passage from version 1 (KJV) to version 111 (NIV) to match handler
packages/ui/src/test/mocks/handlers.ts Updated Isaiah 43:19 handler URL and removed unused version 1 Bible endpoint

Sequence Diagram

sequenceDiagram
    participant Storybook
    participant VerseOfTheDay
    participant Hooks as useVerseOfTheDay/usePassage
    participant MSW as Mock Service Worker
    participant MockData as passages.json
    
    Storybook->>VerseOfTheDay: Render with versionId=111
    VerseOfTheDay->>Hooks: useVerseOfTheDay(dayOfYear)
    Hooks->>MSW: GET /v1/verse_of_the_days/{day}
    MSW-->>Hooks: {passage_id: "ISA.43.19"}
    
    VerseOfTheDay->>Hooks: usePassage(versionId=111, usfm="ISA.43.19")
    Hooks->>MSW: GET /v1/bibles/111/passages/ISA.43.19
    MSW->>MockData: Lookup ISA.43.19
    MockData-->>MSW: {version_id: 111, content: "...", reference: "Isaiah 43:19"}
    MSW-->>Hooks: Passage data
    
    VerseOfTheDay->>Hooks: useVersion(111)
    Hooks->>MSW: GET /v1/bibles/111
    MSW-->>Hooks: {localized_abbreviation: "NIV"}
    
    Hooks-->>VerseOfTheDay: All data loaded
    VerseOfTheDay->>Storybook: Display "Isaiah 43:19 NIV"
Loading

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 6, 2026

Greptile's behavior is changing!

From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section.

This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR".

bmanquen
bmanquen previously approved these changes Jan 6, 2026
@cameronapak cameronapak changed the base branch from agents-md to main January 9, 2026 17:51
@cameronapak cameronapak dismissed bmanquen’s stale review January 9, 2026 17:51

The base branch was changed.

@cameronapak cameronapak closed this Jan 9, 2026
@cameronapak cameronapak force-pushed the YPE-1000-votd-fix-error-loading-verse branch from 56f49c0 to c0eefdf Compare January 9, 2026 17:54
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 9, 2026

No reviewable files after applying ignore patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants