-
Notifications
You must be signed in to change notification settings - Fork 0
YPE-1000 - Fix verse of the day component error loading verses in Storybook #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Greptile SummaryFixed Storybook loading error for Verse of the Day component by standardizing all mock data, handlers, and stories to use version 111 (NIV) instead of the mismatched version 1 (KJV). The issue occurred because the component requested passages from the API with version 1 by default, but the mock handler was configured to respond only to version 111 requests, causing the verse to fail to load in Storybook. Key changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Storybook
participant VerseOfTheDay
participant Hooks as useVerseOfTheDay/usePassage
participant MSW as Mock Service Worker
participant MockData as passages.json
Storybook->>VerseOfTheDay: Render with versionId=111
VerseOfTheDay->>Hooks: useVerseOfTheDay(dayOfYear)
Hooks->>MSW: GET /v1/verse_of_the_days/{day}
MSW-->>Hooks: {passage_id: "ISA.43.19"}
VerseOfTheDay->>Hooks: usePassage(versionId=111, usfm="ISA.43.19")
Hooks->>MSW: GET /v1/bibles/111/passages/ISA.43.19
MSW->>MockData: Lookup ISA.43.19
MockData-->>MSW: {version_id: 111, content: "...", reference: "Isaiah 43:19"}
MSW-->>Hooks: Passage data
VerseOfTheDay->>Hooks: useVersion(111)
Hooks->>MSW: GET /v1/bibles/111
MSW-->>Hooks: {localized_abbreviation: "NIV"}
Hooks-->>VerseOfTheDay: All data loaded
VerseOfTheDay->>Storybook: Display "Isaiah 43:19 NIV"
|
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
56f49c0 to
c0eefdf
Compare
|
No reviewable files after applying ignore patterns. |
https://lifechurch.atlassian.net/browse/YPE-1000
I wanted to test out the agent's files, so even though the agent's pull request isn't yet approved, I branched off of that to create this. Agents file PR: #90
Watch Video Overview