Skip to content

Conversation

@iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jan 27, 2026

Changelog Description

Use product base types to fetch products.

Notes

The kwarg was added in ayon_api 1.2.5 but actually works since ayon_api 1.2.6 which is available since AYON launcher 1.4.3.

Testing notes:

  1. Affected functionality still works (I don't know what it does).

@iLLiCiTiT iLLiCiTiT requested a review from kalisp January 27, 2026 11:22
@iLLiCiTiT iLLiCiTiT self-assigned this Jan 27, 2026
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Jan 27, 2026
@iLLiCiTiT iLLiCiTiT marked this pull request as draft January 29, 2026 11:07
@iLLiCiTiT
Copy link
Member Author

This will work from ayon server 1.14.* .

Copy link

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but!...

This will work from ayon server 1.14.* .

This must be a hard requirement with this PR and added to package.py - if not this query will not list any products that never had assigned any product_base_types.

Which gets extra confusing by the fact that we switch back to product_types argument with older AYON python API.

As such, I'm thinking - maybe it makes most sense to require a newer launcher at least (so that API supports it, because it should not suddenly start querying product_type over product_base_types in the future just because you have old launcher.

If we do any check, we should perhaps check server version instead and if server < 1.14 then use product_types else use product_base_types.

Probably easiest is to just require both, recent launcher and the newer server - only real reliable way here it seems to get the output we want?


In short, this PR should require newer server and newer launcher (for new AYON Python API) but as soon as that's the case, the backwards compatibility logic with the is signature supported can be dropped too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants