Allow external code to provide a seekable (non-file) source#1
Open
volley-se wants to merge 1 commit intoymnk:masterfrom
Open
Allow external code to provide a seekable (non-file) source#1volley-se wants to merge 1 commit intoymnk:masterfrom
volley-se wants to merge 1 commit intoymnk:masterfrom
Conversation
This commit makes VorbisFile.SeekableInputStream public (and static). Previously, only the VorbisFile itself could use it.
volley-se
commented
Oct 2, 2019
Comment on lines
-1382
to
-1391
| public synchronized void mark(int m){ | ||
| } | ||
|
|
||
| public synchronized void reset() throws java.io.IOException{ | ||
| } | ||
|
|
||
| public boolean markSupported(){ | ||
| return false; | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
Removed, no functionality added compared to base class
volley-se
commented
Oct 2, 2019
| } | ||
|
|
||
| class SeekableInputStream extends InputStream{ | ||
| public static abstract class SeekableInputStream extends InputStream { |
Author
There was a problem hiding this comment.
Main change is that this class is now static and public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes VorbisFile.SeekableInputStream public (and static).
Previously, only the VorbisFile itself could use it.