Skip to content

many errors to fix - dont use as base #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yild wants to merge 1 commit into
base: master
Choose a base branch
from
Open

many errors to fix - dont use as base #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion attachments_component/admin/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@
<fieldset name="advanced"
label="ATTACH_CONFIG_ADVANCED_SETTINGS_LABEL">
<field name="max_attachment_size" type="text" size="50" default="0" filter="integer"
label="ATTACH_MAX_ATTACHMENT_SIZE"
label="ATTACH_MAX_ATTACHMENT_SIZE"
description="ATTACH_MAX_ATTACHMENT_SIZE_DESCRIPTION" />
<field name="forbidden_filename_characters" type="text" default="#=?%&amp;"
label="ATTACH_FORBIDDEN_FILENAME_CHARACTERS" size="40"
Expand Down Expand Up @@ -259,6 +259,12 @@

<fieldset name="security"
label="ATTACH_CONFIG_SECURITY_SETTINGS_LABEL">
<field name="test_is_safe_file" type="radio" default="1" layout="joomla.form.field.radio.switcher"
label="ATTACH_TEST_IS_SECURE_FILE"
description="ATTACH_TEST_IS_SECURE_FILE_DESCRIPTION">
<option value="0">JNO</option>
<option value="1">JYES</option>
</field>
<field name="secure" type="radio" default="0" layout="joomla.form.field.radio.switcher"
label="ATTACH_SECURE_ATTACHMENT_DOWNLOADS"
description="ATTACH_SECURE_ATTACHMENT_DOWNLOADS_DESCRIPTION">
Expand Down
92 changes: 85 additions & 7 deletions attachments_component/admin/forms/attachment.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
readonly="true" class="readonly"
/>
<field name="state" type="radio" default="0"
label="JPUBLISHED" description="">
label="JPUBLISHED" description=""
layout="joomla.form.field.radio.switcher"
>
<option value="0">JNO</option>
<option value="1">JYES</option>
</field>
Expand All @@ -24,6 +26,7 @@
/>
<field name="filename" type="file"
label="ATTACH_FILENAME" description="ATTACH_FILENAME_DESCRIPTION"
showon="uri_type:file"
/>
<field name="filename_sys" type="text"
label="ATTACH_SYSTEM_FILENAME" description="ATTACH_SYSTEM_FILENAME_DESCRIPTION"
Expand All @@ -41,24 +44,39 @@
<field name="icon_filename" type="Iconfilenames"
label="ATTACH_ICON_FILENAME" description="ATTACH_ICON_FILENAME_DESCRIPTION"
/>
<field name="uri_type" type="text"
label="ATTACH_ATTACHMENT_TYPE" description=""
readonly="true" class="readonly"
size="10"
/>

<field
name="uri_type"
type="radio"
label=""
description=""
layout="joomla.form.field.radio.switcher"
default="file"
validate="options"
onclick="toggle_url();"
>
<option value="file">ATTACH_ENTER_URL_INSTEAD</option>
<option value="url">ATTACH_SELECT_FILE_TO_UPLOAD_INSTEAD</option>
</field>
<field name="url" type="text"
readonly="true" class="readonly"
label="ATTACH_URL" description="ATTACH_URL_DESCRIPTION"
size="70"
showon="uri_type:url"
/>
<field name="url_valid" type="radio"
label="ATTACH_URL_IS_VALID" description="ATTACH_URL_IS_VALID_TOOLTIP"
label="ATTACH_URL_IS_VALID"
description="ATTACH_URL_IS_VALID_TOOLTIP"
layout="joomla.form.field.radio.switcher"
showon="uri_type:url"
default="1">
<option value="0">JNO</option>
<option value="1">JYES</option>
</field>
<field name="url_relative" type="radio"
label="ATTACH_RELATIVE_URL" description="ATTACH_RELATIVE_URL_TOOLTIP"
layout="joomla.form.field.radio.switcher"
showon="uri_type:url"
default="0">
<option value="0">JNO</option>
<option value="1">JYES</option>
Expand Down Expand Up @@ -106,5 +124,65 @@
readonly="true" class="readonly"
size="10"
/>
<field
name="access"
type="accesslevel"
label="JFIELD_ACCESS_LABEL"
description="JFIELD_ACCESS_DESC"
multiple="false"
>
<option value="">JOPTION_SELECT_ACCESS</option>
</field>
<field
name="parent_type_list"
type="list"
label="ATTACH_PARENT_TYPE"
description="ATTACH_PARENT_TYPE_DESCRIPTION"
default=""
filter="string"
validate="options"
>
<option value="com_content__article">ATTACH_COM_CONTENT_ARTICLE</option>
<option value="com_content__category">ATTACH_COM_CONTENT_CATEGORY</option>
<option value="com_jevents__jevent">JEVENT</option>
</field>
<field
type="spacer"
name="filename_current"
label=""
description="Current file name: zyx"
showon="uri_type:file"
/>
</fieldset>
<fieldset name="content_types">
<field
name="com_content__article"
type="modal_article"
default=""
label="ATTACH_COM_CONTENT_SELECT_ARTICLE"
description="ATTACH_COM_CONTENT_SELECT_ARTICLE_DESCRIPTION"
addfieldprefix="Joomla\Component\Content\Administrator\Field"
showon="parent_type_list:com_content__article"
/>

<field
name="com_content__category"
type="modal_category"
default=""
label="ATTACH_COM_CONTENT_SELECT_CATEGORY"
description="ATTACH_COM_CONTENT_SELECT_CATEGORY_DESCRIPTION"
addfieldprefix="Joomla\Component\Categories\Administrator\Field"
showon="parent_type_list:com_content__category"
/>
<field
name="com_jevents__jevent"
type="JEVselectevent"
default=""
label="ATTACH_SELECT_JEVENT"
description="ATTACH_SELECT_JEVENT_DESC"
addfieldpath="/administrator/components/com_jevents/fields"
showon="parent_type_list:com_jevents__jevent"
/>
</fieldset>

</form>
15 changes: 14 additions & 1 deletion attachments_component/admin/language/en-GB/en-GB.com_attachments.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,4 +414,17 @@ ATTACH_FILE_SIZE_DESC="File Size descending"
ATTACH_MODIFIED_ASC="Modified ascending"
ATTACH_MODIFIED_DESC="Modified descending"
ATTACH_USER_FIELD_N_ASC="%s ascending"
ATTACH_USER_FIELD_N_DESC="%s descending"
ATTACH_USER_FIELD_N_DESC="%s descending"

ATTACH_TEST_IS_SECURE_FILE="Test uploaded file security"
ATTACH_TEST_IS_SECURE_FILE_DESCRIPTION="Test if uploaded file is secure: prevent files with a null byte in their name, do not allow forbiden extensions anywhere in the file's extension, Do not allow `< ? php` or `< ?` tag in content, etc., if set to No - allow all files to be uploaded without checking."

ATTACH_COM_CONTENT_SELECT_ARTICLE="Select an article";
ATTACH_COM_CONTENT_SELECT_ARTICLE_DESCRIPTION="Select an article to which we want Attachment to be attached.";
ATTACH_COM_CONTENT_SELECT_CATEGORY="Select a category";
ATTACH_COM_CONTENT_SELECT_CATEGORY_DESCRIPTION="Select a category to which we want Attachment to be attached.";
ATTACH_COM_CONTENT_ARTICLE="Article"
ATTACH_COM_CONTENT_CATEGORY="Category"

ATTACH_ERROR_INVALID_PARENT_ENTITY_NOT_SELECTED="Entity for parent ID (%d) not selected."
ATTACH_FILENAME_CURRENT="Current file name: %s"
Loading