Skip to content

add comments matter #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madebybo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add comments matter #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ Below is the detailed documentation for review principles, etiquette, and flow.
- Every commit should be accompanied by a message that describes the code change well.
- For major features, merge production code to the feature branch often to ensure backwards compatibility.
- Every PR should have a main assignee, who would sign off on the PR and notify the author to merge the code in.
- All "non-LGTM" comments are considered show-stoppers and must be addressed before merging.
- All code should be well-tested and well-documented during the review process.

## Branching Strategy
Expand Down