Skip to content

PS-6597, PS-6611, PS-6180 - add tagid, divid and allow video.api greater than 0 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ym-eruiz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PS-6597, PS-6611, PS-6180 - add tagid, divid and allow video.api greater than 0 #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce01844
add tagid, divid and allow video.api greater than 0
ym-eruiz Feb 25, 2025
124fa12
add tagid, divid and allow video.api greater than 0
ym-eruiz Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion modules/yieldmoBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,8 @@ function hasVideoMediaType(bidRequest) {
*/
function addPlacement(request) {
const gpid = deepAccess(request, 'ortb2Imp.ext.gpid') || deepAccess(request, 'ortb2Imp.ext.data.pbadslot');
const tagid = deepAccess(request, 'ortb2Imp.ext.tagid');
const divid = deepAccess(request, 'ortb2Imp.ext.divid');
const placementInfo = {
placement_id: request.adUnitCode,
callback_id: request.bidId,
Expand All @@ -275,6 +277,12 @@ function addPlacement(request) {
if (gpid) {
placementInfo.gpid = gpid;
}
if (tagid) {
placementInfo.tagid = tagid;
}
if (divid) {
placementInfo.divid = divid;
}

// get the transaction id for the banner bid.
const transactionId = deepAccess(request, 'ortb2Imp.ext.tid');
Expand Down Expand Up @@ -471,6 +479,8 @@ function getTopics(bidderRequest) {
*/
function openRtbImpression(bidRequest) {
const gpid = deepAccess(bidRequest, 'ortb2Imp.ext.gpid') || deepAccess(bidRequest, 'ortb2Imp.ext.data.pbadslot');
const tagid = deepAccess(bidRequest, 'ortb2Imp.ext.tagid');
const divid = deepAccess(bidRequest, 'ortb2Imp.ext.divid');
const size = extractPlayerSize(bidRequest);
const imp = {
id: bidRequest.bidId,
Expand Down Expand Up @@ -508,6 +518,12 @@ function openRtbImpression(bidRequest) {
if (gpid) {
imp.ext.gpid = gpid;
}
if (tagid) {
imp.ext.tagid = tagid;
}
if (divid) {
imp.ext.divid = divid;
}
return imp;
}

Expand Down Expand Up @@ -655,7 +671,8 @@ function validateVideoParams(bid) {
validate('video.protocols', val => isDefined(val), paramRequired);

validate('video.api', val => isDefined(val), paramRequired);
validate('video.api', val => isArrayOfNums(val) && val.every(v => (v >= 1 && v <= 6)),
// PS-6597 - Allow video.api to be any number greater than 0
validate('video.api', val => isArrayOfNums(val) && val.every(v => (v >= 1)),
paramInvalid, 'array of numbers, ex: [2,3]');

validate('video.playbackmethod', val => !isDefined(val) || isArrayOfNums(val), paramInvalid,
Expand Down