Skip to content

Yieldmo adapter: use POST instead of GET for banner requests #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ym-atsymuk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Yieldmo adapter: use POST instead of GET for banner requests #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/yieldmoBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export const spec = {
});
serverRequest.p = '[' + serverRequest.p.toString() + ']';
serverRequests.push({
method: 'GET',
method: 'POST',
url: BANNER_SERVER_ENDPOINT,
data: serverRequest
});
Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/yieldmoBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,10 @@ describe('YieldmoAdapter', function () {
utils.deepAccess(build(bidRequests, bidderReq), `${index}.data`) || {};

describe('Banner:', function () {
it('should attempt to send banner bid requests to the endpoint via GET', function () {
it('should attempt to send banner bid requests to the endpoint via POST', function () {
const requests = build([mockBannerBid()]);
expect(requests.length).to.equal(1);
expect(requests[0].method).to.equal('GET');
expect(requests[0].method).to.equal('POST');
expect(requests[0].url).to.be.equal(BANNER_ENDPOINT);
});

Expand Down