Skip to content

Conversation

@benlife5
Copy link
Contributor

@benlife5 benlife5 commented Jan 13, 2026

  • Sets all screenshots to useFullPage
  • Removes original (non-expanded) header/footer tests
  • Cleans up first half of screenshot tests by removing unnecessary/redundant screenshots
    • If a component migrates cleanly from version x to x+1 and x+1 to x+2, then we don't need to text the x to x+2 migration. Theoretically, we only need to keep tests for the current version and the version before it.
    • However, sometimes keeping older prop versions provides increased test coverage of different variations of a component

@github-actions
Copy link
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants