feat(aggregation-mode): add grafana dashboard #2218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
67
to
72
| let prometheus = PrometheusMetricsBuilder::new("api") | ||
| .endpoint("/metrics") | ||
| .const_labels(labels) | ||
| .build() | ||
| .unwrap(); | ||
|
|
Member
There was a problem hiding this comment.
this should be created in the GatewayMetrics.
Collaborator
Author
There was a problem hiding this comment.
It needs to be created in GatewayServer::start because it's a layer built on top of the Actix server, so it must be instantiated when the server is created.
aggregation_mode/gateway/src/http.rs
Outdated
Comment on lines
262
to
264
| state | ||
| .metrics | ||
| .register_db_response_time_post(duration.as_secs_f64()); |
Member
There was a problem hiding this comment.
This metrics should have a label to identify the query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description of the pull request changes and motivation.
How to test
Now you can see the
Aggregation Modedashboard onhttp://localhost:3000/dashboards.Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging