feat(aggregation-mode): retry bump and sending proofs on-chain after proof aggregation #2211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /// Supports retries only on async functions. See: https://docs.rs/backon/latest/backon/#retry-an-async-function | ||
| /// Runs with `jitter: false`. | ||
| pub async fn retry_function<FutureFn, Fut, T, E>( |
Member
There was a problem hiding this comment.
I wouldn't move this functions here. This file should only contain the abstraction to interact with backon or any retryable library, not business logic.
Collaborator
Author
There was a problem hiding this comment.
Moved back to the mod.rs file in 5a728d1
Comment on lines
316
to
317
| #[cfg(test)] | ||
| mod tests { |
Member
There was a problem hiding this comment.
If the should_send_proof_to_verify_on_chain is now in helpers it does not make much sense for them to be here. They should be moved to helpers.rs.
|
|
||
| /// Supports retries only on async functions. See: https://docs.rs/backon/latest/backon/#retry-an-async-function | ||
| /// Runs with `jitter: false`. | ||
| pub async fn retry_function<FutureFn, Fut, T, E>( |
Member
There was a problem hiding this comment.
I would remove bakon and write the backoff delay logic ourselves, it should be 10 lines of code. The usage of callbacks in bakon makes the code complex and hard to follow/read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a retry logic with exponential backoff.
How to test
Normal workflow
Failure after retries
Do the same steps as before, but before step 4, go to the Docker container which maps the port 8545 (usually a
el-X-geth-lighthouse) and shut it down.Success after retries
The same as before, but when you see the first
Started waiting until we can submit the aggregated proof.log, then start the container.Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging