Better support for Dragonfly memcache facade #16
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've bumped into issues when attempting to use gets and gats with a memcache compatible facade for DragonFly
They did not fully implement the basic text protocol have in some cases changed the behavior of some commands
After further researching, I've found that the
getandgatcommands can return more than just one key and decided to add a simple condition inGetsandGetsAndTouchto specify whether the user wants to use CAS commandsI've made sure that this change would not break existing codebases but more testing would be great
https://docs.memcached.org/protocols/basic/#get