Add checks for Apple arm processor arch and Resolve merge conflicts#41
Merged
yeongbin-jo merged 1 commit intoyeongbin-jo:masterfrom Jul 5, 2023
hcooch2ch3:master
Merged
Add checks for Apple arm processor arch and Resolve merge conflicts#41yeongbin-jo merged 1 commit intoyeongbin-jo:masterfrom hcooch2ch3:master
yeongbin-jo merged 1 commit intoyeongbin-jo:masterfrom
hcooch2ch3:master
Conversation
ddl-michael-noonan
approved these changes
Jun 12, 2023
ddl-michael-noonan
left a comment
ddl-michael-noonan
left a comment
There was a problem hiding this comment.
I need this fix and this is exactly what I was hoping to find as the fix, you even went the extra mile to accommodate for older version of chromedriver where they didn't use arm in the naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a merge conflict in pull request #35, so I have resolved it and will submit a revised PR.
@chadfrost
I'm currently using an Apple M1 MacBook, but I find it inconvenient in my project... I kindly request a prompt review plz.
@yeongbin-jo