Merged
Conversation
Signed-off-by: Yogev Neumann <xqgex@users.noreply.github.com>
Contributor
CI ReportCommit: Static Analysis
cppcheckClick to expandclang-tidyClick to expandSanitizers (ASan + UBSan)Test Output✅ No issues detected Valgrind Memory CheckTest Output✅ No memory issues detected |
There was a problem hiding this comment.
Pull request overview
This PR introduces a make pre-push command that consolidates all CI validation checks into a single local command, making it easier for contributors to verify their changes before pushing. The implementation auto-detects available GCC (11+) and Clang (13+) compilers and tests with boundary versions (minimum and maximum found).
Changes:
- Added comprehensive
pre-pushtarget that runs format, multi-compiler build/test, cppcheck, clang-tidy, sanitizers, and valgrind in sequence - Implemented smart compiler auto-detection using Make's
foreachandiffunctions to test with available GCC 11+ and Clang 13+ versions - Reorganized Makefile targets alphabetically for better maintainability
- Updated all documentation (README, CONTRIBUTING, PR template, Copilot instructions) to reference the new
pre-pushcommand, simplifying contributor workflows
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Makefile | Added compiler auto-detection logic and comprehensive pre-push target; reorganized all targets alphabetically; improved help text |
| Makefile | Added pre-push target delegation; reorganized targets alphabetically; removed duplicate help text (now delegated to tests/Makefile) |
| README.md | Added make pre-push to the Build & Test command reference |
| CONTRIBUTING.md | Simplified submission steps from 5 to 4 by consolidating test/check commands into single make pre-push command |
| .github/pull_request_template.md | Reduced checklist from 6 items to 4 by replacing 3 separate check items with single make pre-push requirement |
| .github/copilot-instructions.md | Updated Definition of Done to reference make pre-push instead of just make all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add
make pre-pushfor local CI validationpre-pushtarget to Makefile that replicates full CI pipeline locally$(foreach)/$(if)make pre-push:README.md: Addpre-pushin Build & Test sectionCONTRIBUTING.md: Simplify submission steps (4-5 → 4)Related Issue
N/A
Additional Notes
N/A
Type of Change
Checklist
make test)make check)make valgrindandmake sanitize)git commit -s