DEV: added robot file #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.ropeproject .gitignore
CJ-Wright
reviewed
Jul 24, 2017
xpdsim/robot.py
Outdated
| self._current_sample_geometry = None | ||
| super().__init__(name, fields, initial_set, **kwargs) | ||
|
|
||
| def load_sample(self, saple_number, sample_geometry=None): |
CJ-Wright
reviewed
Jul 25, 2017
xpdsim/dets.py
Outdated
|
|
||
|
|
||
| def build_image_cycle(path): | ||
| # Goal: replace this with a mediator to the robot, to be handled in |
Member
There was a problem hiding this comment.
The image cycle stuff is fine. The issue is how that image cycle is handed to the detector
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
===========================================
- Coverage 93.54% 67.28% -26.27%
===========================================
Files 6 7 +1
Lines 155 217 +62
===========================================
+ Hits 145 146 +1
- Misses 10 71 +61
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.