Fix pandas DataFrame.eval() numexpr compatibility (Issue #436) #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a compatibility issue where pandas DataFrame.eval() defaults to the numexpr engine, which is incompatible with the expression patterns used in Issue #436.
The fix explicitly sets engine="python" at the affected eval call sites. This approach is conservative and backward-compatible, preserves existing behavior, and avoids changing the expression logic or public APIs.
Tests were run locally but fail early due to a missing optional dependency (python-dotenv required by tests/conftest.py). No failures are related to this change. Maintainers can run the full test suite in their environment.